From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Chris Larson <clarson@kergoth.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 1/1] bitbake: enable cleanup of WORKDIR
Date: Fri, 02 Mar 2012 16:36:28 +0000 [thread overview]
Message-ID: <1330706188.309.15.camel@ted> (raw)
In-Reply-To: <CABcZANmgbf_fDAxsqOkzzNX2t81u2tkeGsgibgo3nDyQzA1vng@mail.gmail.com>
On Fri, 2012-03-02 at 08:33 -0700, Chris Larson wrote:
> On Fri, Mar 2, 2012 at 12:54 AM, Kang Kai <kai.kang@windriver.com> wrote:
> > [Yocto 1561]
> > Add a command line option for bitbake to enable cleanup of WORKDIR.
> > It checks every package build directories under WORKDIR then parse
> > the directory name to get package name and version. If the version
> > is not the package prefer version then delete the directory.
> >
> > Signed-off-by: Kang Kai <kai.kang@windriver.com>
> > ---
> > bitbake/bin/bitbake | 4 +++
> > bitbake/lib/bb/command.py | 5 +++
> > bitbake/lib/bb/cooker.py | 63 +++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 72 insertions(+), 0 deletions(-)
>
> This is wrong on multiple levels. bitbake (other than some hacky stuff
> in the fetcher that needs to die) has *zero* knowledge of the use of
> WORKDIR today, that's entirely metadata implementation.
Totally agreed. I saw a comment earlier today in the bugzilla about this
and made the same comment even before I saw this patch...
Cheers,
Richard
next prev parent reply other threads:[~2012-03-02 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 7:54 [PATCH 0/1] Yocto 1561: enable cleanup of WORKDIR Kang Kai
2012-03-02 7:54 ` [PATCH 1/1] bitbake: " Kang Kai
2012-03-02 15:33 ` Chris Larson
2012-03-02 16:36 ` Richard Purdie [this message]
2012-03-05 2:30 ` Kang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330706188.309.15.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=clarson@kergoth.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.