From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
open11s <devel@lists.open80211s.org>
Subject: Re: [PATCH v2 2/2] mac80211: fix mesh airtime link metric estimating
Date: Mon, 05 Mar 2012 07:55:34 +0100 [thread overview]
Message-ID: <1330930534.3545.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAG6hwVMpZTG=vuidSvQvvJhBj=avW_JP5ewATLwTCZsNqcu5zw@mail.gmail.com> (sfid-20120304_235047_838378_68018E05)
On Sun, 2012-03-04 at 14:49 -0800, Thomas Pedersen wrote:
> >> For stack usage, it'd be better if you gave this two arguments (struct
> >> rate_info *txrate, struct rate_info *rxrate), or maybe simply factored
> >> out *only* the TX-rate bit?
> >>
> >
> > like sta_set_rate_info(struct sta_info *sta, struct rate_info *txrate,
> > struct rate_info *rxrate)?
> >
> > How do you feel about consolidating last_rx_flags and _index into an
> > ieee80211_tx_rate? A bit odd maybe, but then we could use:
> >
> > sta_set_rate_info(struct ieee80211_tx_rate *rate, struct rate_info *rinfo);
> >
> > As needed for both last_rx and last_tx rates.
Seems a little odd to first translate RX rate into TX rate and then to
cfg80211 info? But you only care about TX rate anyway so ... why worry
at all?
johannes
prev parent reply other threads:[~2012-03-05 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 23:46 [PATCH v2 1/2] cfg80211: expose cfg80211_calculate_bitrate() Thomas Pedersen
2012-03-02 23:46 ` [PATCH v2 2/2] mac80211: fix mesh airtime link metric estimating Thomas Pedersen
2012-03-03 11:37 ` Johannes Berg
[not found] ` <CAG6hwVMo2ZgcNYDQ3UKRC2Wo_gibERBdgvaLWJmi52min8w3Hg@mail.gmail.com>
2012-03-04 22:49 ` Thomas Pedersen
2012-03-05 6:55 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330930534.3545.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=linux-wireless@vger.kernel.org \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.