All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: DAPM - Make sure DAPM widget IO ops hold the component mutex.
Date: Wed, 07 Mar 2012 10:11:01 +0000	[thread overview]
Message-ID: <1331115061.3829.11.camel@odin> (raw)
In-Reply-To: <20120306200354.GB19635@opensource.wolfsonmicro.com>

On Tue, 2012-03-06 at 20:03 +0000, Mark Brown wrote:
> On Tue, Mar 06, 2012 at 06:16:19PM +0000, Liam Girdwood wrote:
> 
> > +	if (w->codec)
> > +		mutex_lock(&w->codec->mutex);
> 
> Actually for CODECs we don't need to hold the CODEC mutex for I/O if
> we've pushed the cache down into regmap - regmap does all the locking
> for us.  I'll send a followup patch.

I know, but this patch did check for regmap usage in
soc_widget_update_bits_locked(). With your fix we are doing the regmap
test twice.

Liam

  reply	other threads:[~2012-03-07 10:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06 18:16 [PATCH 1/2] ASoC: core - Add platform component mutex Liam Girdwood
2012-03-06 18:16 ` [PATCH 2/2] ASoC: DAPM - Make sure DAPM widget IO ops hold the " Liam Girdwood
2012-03-06 20:03   ` Mark Brown
2012-03-07 10:11     ` Liam Girdwood [this message]
2012-03-07 10:54       ` Mark Brown
2012-03-07 11:13         ` Liam Girdwood
2012-03-07 20:00           ` Mark Brown
2012-03-09 17:26   ` Tabi Timur-B04825
2012-03-09 18:14     ` Liam Girdwood
2012-03-09 19:11       ` Timur Tabi
2012-03-11 12:55         ` Mark Brown
2012-03-11 13:58           ` Tabi Timur-B04825
2012-03-12  9:12           ` Shawn Guo
2012-03-12  9:27             ` Liam Girdwood
2012-03-12 10:42               ` Mark Brown
2012-03-06 20:09 ` [PATCH 1/2] ASoC: core - Add platform " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331115061.3829.11.camel@odin \
    --to=lrg@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.