From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] xen: Make sure log-dirty is turned off before trying to dismantle it Date: Thu, 8 Mar 2012 12:26:02 +0000 Message-ID: <1331209562.32288.47.camel@elijah> References: <44b93337f0385079af8b.1331143125@drall.uk.xensource.com> <20120308121712.GE64337@ocelot.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120308121712.GE64337@ocelot.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: George Dunlap , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Thu, 2012-03-08 at 12:17 +0000, Tim Deegan wrote: > At 17:58 +0000 on 07 Mar (1331143125), George Dunlap wrote: > > diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c > > --- a/xen/arch/x86/mm/paging.c > > +++ b/xen/arch/x86/mm/paging.c > > @@ -722,6 +722,10 @@ int paging_domctl(struct domain *d, xen_ > > /* Call when destroying a domain */ > > void paging_teardown(struct domain *d) > > { > > + /* Make sure log-dirty is turned off before trying to dismantle it. > > + * Needs to be done here becuse it's covered by the hap/shadow lock */ > > + d->arch.paging.log_dirty.disable_log_dirty(d); > > + > > if ( hap_enabled(d) ) > > hap_teardown(d); > > else > > > > This isn't needed upstream because the spinlock confusion that it's > papering over has been properly fixed (by eliminating the log-dirty > lock). Yes; I'm afraid I didn't read the ticket referenced here very well either. Sorry about that -- it just looked so obvious. :-) It looks like Keir has already added it -- do you want to revert it? -George