From: Steven Rostedt <srostedt@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Rob Lee <rob.lee@linaro.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: linux-next: manual merge of the cpuidle-cons tree with the tip tree
Date: Fri, 09 Mar 2012 08:35:09 -0500 [thread overview]
Message-ID: <1331300109.1149.17.camel@fedora> (raw)
In-Reply-To: <20120309184041.bd10edffa51dcd43ce069487@canb.auug.org.au>
On Fri, 2012-03-09 at 18:40 +1100, Stephen Rothwell wrote:
> diff --cc drivers/cpuidle/cpuidle.c
> index 6588f43,56de5f7..0000000
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@@ -92,15 -109,13 +109,13 @@@ int cpuidle_idle_call(void
> return 0;
> }
>
> - target_state = &drv->states[next_state];
> -
> - trace_power_start(POWER_CSTATE, next_state, dev->cpu);
> - trace_cpu_idle(next_state, dev->cpu);
> + trace_power_start_rcuidle(POWER_CSTATE, next_state, dev->cpu);
> + trace_cpu_idle_rcuidle(next_state, dev->cpu);
>
> - entered_state = target_state->enter(dev, drv, next_state);
> + entered_state = cpuidle_enter_ops(dev, drv, next_state);
>
> - trace_power_end(dev->cpu);
> - trace_cpu_idle(PWR_EVENT_EXIT, dev->cpu);
> + trace_power_end_rcuidle(dev->cpu);
> + trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, dev->cpu);
>
Looks good. My change was just a rename of trace_power_* and
trace_cpu_*, and it looks like another change was the clean up of
target_state. This is a trivial conflict, and there should be no
surprises here.
-- Steve
> if (entered_state >= 0) {
> /* Update cpuidle counters */
next prev parent reply other threads:[~2012-03-09 13:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 7:40 linux-next: manual merge of the cpuidle-cons tree with the tip tree Stephen Rothwell
2012-03-09 13:35 ` Steven Rostedt [this message]
2012-03-12 17:06 ` Rob Lee
2012-03-12 17:13 ` Steven Rostedt
2012-03-12 23:08 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331300109.1149.17.camel@fedora \
--to=srostedt@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rob.lee@linaro.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.