From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S71as-0004ly-4x for qemu-devel@nongnu.org; Mon, 12 Mar 2012 05:31:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S71am-0006GO-1e for qemu-devel@nongnu.org; Mon, 12 Mar 2012 05:31:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S71al-0006G9-Qj for qemu-devel@nongnu.org; Mon, 12 Mar 2012 05:30:59 -0400 From: Kevin Wolf Date: Mon, 12 Mar 2012 10:34:28 +0100 Message-Id: <1331544868-31655-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1331544868-31655-1-git-send-email-kwolf@redhat.com> References: <1331544868-31655-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] tracetool: Forbid argument name 'next' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stefanha@gmail.com Cc: kwolf@redhat.com, qemu-devel@nongnu.org It has happened more than once that patches that look perfectly sane and work with simpletrace broke systemtap because they use 'next' as an argument name for a tracing function. However, 'next' is a keyword for systemtap, so we shouldn't use it. Signed-off-by: Kevin Wolf --- scripts/tracetool | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index 4c9951d..f892af4 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -81,6 +81,10 @@ get_args() args=${1#*\(} args=${args%%\)*} echo "$args" + + if (echo "$args" | grep "[ *]next\($\|[, ]\)" > /dev/null 2>&1); then + echo -e "\n#error 'next' is a bad argument name (clash with systemtap keyword)\n " + fi } # Get the argument name list of a trace event -- 1.7.6.5