From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: ipv4: Standardize prefixes for message logging
Date: Mon, 12 Mar 2012 17:35:52 -0700 [thread overview]
Message-ID: <1331598952.13200.43.camel@joe2Laptop> (raw)
In-Reply-To: <20120312.170558.584205292599435892.davem@davemloft.net>
On Mon, 2012-03-12 at 17:05 -0700, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Mon, 12 Mar 2012 10:03:32 -0700
> > Add #define pr_fmt(fmt) as appropriate.
> > Add "IPv4: ", "TCP: ", and "IPsec: " to appropriate files.
> > Standardize on "UDPLite: " for appropriate uses.
> > Some prefixes were previously "UDPLITE: " and "UDP-Lite: ".
[]
> Looks good, and applied,
OK. I'll submit a similar change for net/ipv6 in awhile.
> but I left out this hunk:
> > diff --git a/net/ipv4/ipcomp.c b/net/ipv4/ipcomp.c
> > index 63b64c4..56d6768 100644
> > --- a/net/ipv4/ipcomp.c
> > +++ b/net/ipv4/ipcomp.c
> > @@ -13,6 +13,7 @@
> > * - Compression stats.
> > * - Adaptive compression.
> > */
> > +
> > #include <linux/module.h>
> > #include <linux/err.h>
> > #include <linux/rtnetlink.h>
>
> As it seemed accidental, if not gratuitous.
It wasn't accidental, though I could have mentioned it
in the changelog. Most files have a blank line between
an initial block commment and the first #include.
I just do that by habit when looking if a file could
benefit from a #define pr_fmt.
I added a similar blank line to udplite.c, but there
I also added pr_fmt.
cheers, Joe
next prev parent reply other threads:[~2012-03-13 0:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 4:36 [PATCH net-next] net: Convert printks to pr_<level> Joe Perches
2012-03-12 6:48 ` David Miller
2012-03-12 17:03 ` [PATCH net-next] net: ipv4: Standardize prefixes for message logging Joe Perches
2012-03-13 0:05 ` David Miller
2012-03-13 0:35 ` Joe Perches [this message]
2012-03-19 21:00 ` Joe Perches
2012-03-19 21:03 ` David Miller
2012-03-19 21:14 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331598952.13200.43.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.