From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 01/17] leafpad: Package currently unpackaged files.
Date: Tue, 13 Mar 2012 09:52:14 +0000 [thread overview]
Message-ID: <1331632334.15192.35.camel@ted> (raw)
In-Reply-To: <63F58257-6C34-409B-948C-B4C1D0CAF211@dominion.thruhere.net>
On Tue, 2012-03-13 at 09:07 +0100, Koen Kooi wrote:
> Op 13 mrt. 2012, om 01:22 heeft Richard Purdie het volgende geschreven:
>
> > This resolves the QA warning:
> >
> > WARNING: For recipe leafpad, the following files/directories were installed but not shipped in any package:
> > WARNING: /usr/share/icons
> > WARNING: /usr/share/icons/hicolor
> > WARNING: /usr/share/icons/hicolor/16x16
> > WARNING: /usr/share/icons/hicolor/22x22
> > WARNING: /usr/share/icons/hicolor/scalable
> > WARNING: /usr/share/icons/hicolor/32x32
> > WARNING: /usr/share/icons/hicolor/24x24
> > WARNING: /usr/share/icons/hicolor/16x16/apps
> > WARNING: /usr/share/icons/hicolor/16x16/apps/leafpad.png
> > WARNING: /usr/share/icons/hicolor/22x22/apps
> > WARNING: /usr/share/icons/hicolor/22x22/apps/leafpad.png
> > WARNING: /usr/share/icons/hicolor/scalable/apps
> > WARNING: /usr/share/icons/hicolor/scalable/apps/leafpad.svg
> > WARNING: /usr/share/icons/hicolor/32x32/apps
> > WARNING: /usr/share/icons/hicolor/32x32/apps/leafpad.png
> > WARNING: /usr/share/icons/hicolor/24x24/apps
> > WARNING: /usr/share/icons/hicolor/24x24/apps/leafpad.png
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> > meta/recipes-sato/leafpad/leafpad_0.8.18.1.bb | 6 ++++--
> > 1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-sato/leafpad/leafpad_0.8.18.1.bb b/meta/recipes-sato/leafpad/leafpad_0.8.18.1.bb
> > index 68402c5..3d1bc43 100644
> > --- a/meta/recipes-sato/leafpad/leafpad_0.8.18.1.bb
> > +++ b/meta/recipes-sato/leafpad/leafpad_0.8.18.1.bb
> > @@ -1,6 +1,5 @@
> > DESCRIPTION = "Simple GTK+ Text Editor"
> > HOMEPAGE = "http://tarot.freeshell.org/leafpad/"
> > -BUGTRACKER = ""
> >
> > LICENSE = "GPLv2 & GPLv2+"
> > LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
> > @@ -14,7 +13,7 @@ SRC_URI = "http://savannah.nongnu.org/download/${BPN}/${BPN}-${PV}.tar.gz \
> >
> > SRC_URI[md5sum] = "254a72fc67505e3aa52884c729cd7b97"
> > SRC_URI[sha256sum] = "959d22ae07f22803bc66ff40d373a854532a6e4732680bf8a96a3fbcb9f80a2c"
> > -PR = "r1"
> > +PR = "r2"
> >
> > SRC_URI_append_poky += " file://owl-menu.patch;apply=yes "
> >
> > @@ -29,3 +28,6 @@ do_install_append () {
> > }
> >
> > FILES_${PN} += "${datadir}/applications/leafpad.desktop"
> > +
> > +PACKAGES += "leafpad-stock-icons"
> > +FILES_leafpad-stock-icons = "${datadir}/icons/hicolor/"
>
> I strongly suspect that that .desktop will reference leafpad.png as
> the icon, but I haven't actually verified that.
I can confirm it does not (it references accessories-text-editor).
> This recipe should probably inherit gtk-icon-cache.
Probably although given the above it becomes less of an issue.
Cheers,
Richard
next prev parent reply other threads:[~2012-03-13 10:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 0:22 [PATCH 00/17] Various warning fixes Richard Purdie
2012-03-13 0:22 ` [PATCH 01/17] leafpad: Package currently unpackaged files Richard Purdie
2012-03-13 8:07 ` Koen Kooi
2012-03-13 9:52 ` Richard Purdie [this message]
2012-03-13 9:54 ` Martin Jansa
2012-03-13 17:49 ` Richard Purdie
2012-03-13 0:22 ` [PATCH 02/17] xf86-input-vmmouse: Package " Richard Purdie
2012-03-13 0:22 ` [PATCH 03/17] sato-screenshot: Remove unneeded .la file Richard Purdie
2012-03-13 0:22 ` [PATCH 04/17] librsvg: Fix unpackaged directory warnings Richard Purdie
2012-03-13 0:22 ` [PATCH 05/17] matchbox-session: Clarify LICENSE as GPLv2 Richard Purdie
2012-03-13 0:22 ` [PATCH 06/17] wireless-tools: Clarify LICENSE field to avoid warnings Richard Purdie
2012-03-13 0:22 ` [PATCH 07/17] gtk-doc: Clarify license as GPLv2 Richard Purdie
2012-03-13 0:22 ` [PATCH 08/17] gnome-doc-utils: Clarify license as GPLv2 and LGPLv2.1 Richard Purdie
2012-03-13 0:22 ` [PATCH 09/17] boost: Correct license name BSL-1 -> BSL-1.0 Richard Purdie
2012-03-13 0:22 ` [PATCH 10/17] shadow: Correct license Artistic -> Artistic-1.0 Richard Purdie
2012-03-13 0:22 ` [PATCH 11/17] perl: Clarify LICENSE with versions. Yes, its really GPLv1 Richard Purdie
2012-03-13 0:22 ` [PATCH 12/17] license.bbclass: Add mapping for LGPLv2.0, pango uses it Richard Purdie
2012-03-13 0:22 ` [PATCH 13/17] qemu-config: Clarify license as GPLv2 Richard Purdie
2012-03-13 0:22 ` [PATCH 14/17] bluez4: Ensure the plugins directory is packaged to avoid warnings Richard Purdie
2012-03-13 0:22 ` [PATCH 15/17] rpm: Add rpmdeps-oecore to appropriate package Richard Purdie
2012-03-13 0:22 ` [PATCH 16/17] python-pycairo: Fix incorrect versions in license field Richard Purdie
2012-03-13 0:22 ` [PATCH 17/17] xserver-xorg: Remove unneeded empty directory, fixing QA warning Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331632334.15192.35.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.