All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [CONSOLIDATED PULL 11/23] arch-powerpc.inc: use default value of TUNE_PKGARCH
Date: Tue, 13 Mar 2012 11:43:38 +0000	[thread overview]
Message-ID: <1331639018.15192.36.camel@ted> (raw)
In-Reply-To: <a1dc1d991303525abfc81d1b7ff29ecd87073ff1.1331589797.git.sgw@linux.intel.com>

On Tue, 2012-03-13 at 00:58 -0700, Saul Wold wrote:
> From: Matthew McClintock <msm@freescale.com>
> 
> We can use the default value for TUNE_PKGARCH, and now we just
> append "-nf" if TARGET_FPU is fpu-soft
> 
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>  meta/conf/machine/include/powerpc/arch-powerpc.inc |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/meta/conf/machine/include/powerpc/arch-powerpc.inc b/meta/conf/machine/include/powerpc/arch-powerpc.inc
> index c9b2829..9f588e8 100644
> --- a/meta/conf/machine/include/powerpc/arch-powerpc.inc
> +++ b/meta/conf/machine/include/powerpc/arch-powerpc.inc
> @@ -18,10 +18,8 @@ TARGET_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "fpu-soft", "soft", "", d)}
>  
>  ABIEXTENSION = "${@['','spe'][d.getVar('TARGET_FPU', True) in ['ppc-efd', 'ppc-efs']]}"
>  
> -PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-hard" , "", "-nf", d)}"
> -
> -PPCPKGARCH = "${TUNE_ARCH}${PPCPKGSFX_FPU}"
> -TUNE_PKGARCH ?= "${PPCPKGARCH}"
> +PPCPKGSFX_FPU = "${@['', '-nf'][d.getVar('TARGET_FPU',d,1) in ['fpu-soft']]}"
> +TUNE_PKGARCH_append = "${PPCPKGSFX_FPU}"

This patch is unlikely to work:

d.getVar('TARGET_FPU',d,1)

(note the duplicate d)

Cheers,

Richard







  reply	other threads:[~2012-03-13 11:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13  7:58 [CONSOLIDATED PULL 00/23] Catching up after conference Time Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 01/23] linux-yocto: respect FILESPATH directories Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 02/23] glib-2.0: Add Upstream Status for nodbus.patch Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 03/23] run-postinsts: fix opkg data path Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 04/23] image.bbclass: fix rootfs generation without package management tools Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 05/23] rootfs_rpm.bbclass: rename postinst trigger script Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 06/23] opkg: " Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 07/23] dpkg: " Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 08/23] trace-cmd: modifying License information Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 09/23] image-vmdk: add NOISO to disable iso image creation since it's not needed Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 10/23] packagedata.py: Fix get_subpkgedata_fn for multilib Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 11/23] arch-powerpc.inc: use default value of TUNE_PKGARCH Saul Wold
2012-03-13 11:43   ` Richard Purdie [this message]
2012-03-13  7:58 ` [CONSOLIDATED PULL 12/23] qt4: fix deps in libQtWebkit.la and QtWebKit.pc Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 13/23] udev-164: fixup "don't hardcode path to pidof" Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 14/23] image_types: ensure .rootfs.ext3 is created before vmdk is created Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 15/23] connman: update to 0.79 Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 16/23] package.bbclass: sort dynamically generated packages Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 17/23] util-linux: explicitly disable udev Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 18/23] linux-firmware: fix permissions of installed files Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 19/23] python, python-native: always set platform to linux2 Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 20/23] python: regenerate plat-linux2/*.py Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 21/23] python: depend on bzip2 Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 22/23] python-native: distutils: don't use libdir, remove dead code path Saul Wold
2012-03-13  7:58 ` [CONSOLIDATED PULL 23/23] python, python-native: bump PR Saul Wold
2012-03-13 11:48 ` [CONSOLIDATED PULL 00/23] Catching up after conference Time Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331639018.15192.36.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.