From: Marcel Holtmann <marcel@holtmann.org>
To: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix broken usage of get_unaligned_le16
Date: Tue, 13 Mar 2012 08:15:51 -0700 [thread overview]
Message-ID: <1331651751.14217.93.camel@aeonflux> (raw)
In-Reply-To: <20120313072933.GA15895@aemeltch-MOBL1>
Hi Andrei,
> > In case the struct is already __packed, there is no need to use unaligned
> > access to the data. So just use __le16_to_cpu in these cases.
>
> One minor comment related to use of __xxx versions. What is the general
> rule when to use __le16_to_cpu and when le16_to_cpu? In mgmt.c looks that
> mostly in use version without underscore.
honestly I do not know. We have been using __le16_to_cpu and cpu_to_le16
as long as I can remember.
Regards
Marcel
next prev parent reply other threads:[~2012-03-13 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 3:31 [PATCH] Bluetooth: Fix broken usage of get_unaligned_le16 Marcel Holtmann
2012-03-13 7:29 ` Andrei Emeltchenko
2012-03-13 15:15 ` Marcel Holtmann [this message]
2012-03-16 15:36 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331651751.14217.93.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.