All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: intel-gfx@lists.freedesktop.org, hcb@chaoticmind.net
Subject: Re: Thinkpad T420 and single/dual channel lvds
Date: Wed, 14 Mar 2012 14:09:19 -0400	[thread overview]
Message-ID: <1331748559.30864.14.camel@atropine> (raw)
In-Reply-To: <s5hpqcfxhc7.wl%tiwai@suse.de>


[-- Attachment #1.1: Type: text/plain, Size: 1338 bytes --]

On Wed, 2012-03-14 at 17:44 +0100, Takashi Iwai wrote:
> At Wed, 14 Mar 2012 10:45:06 -0400,
> Adam Jackson wrote:
> > There may or may not be a bit for this in the VBT in the BIOS.  But the
> > more reliably correct thing I suspect would be to just look at the
> > preferred mode for the panel and assume it's dual-link LVDS if the pixel
> > clock is >112MHz, since that's the crossover frequency.
> 
> Coincidently, we hit the same issue with a HP laptop, and wondered how
> is the best way to fix.  I hoped BIOS could handle better,
> i.e. setting the power bits no matter whether the lid is opened or
> not.  But it doesn't set unless the lid is once opened.
> 
> (Interestingly, the bits remain even if you close the lid again before
>  booting.  Just opening once seems triggering the probing of LVDS
>  panel in BIOS and let it setting the right values.)
> 
> FWIW, when I check ironalke_crtc_mode_set(), the clock of the HD+
> LVDS mode (1600x900) is 107800 (refclk 120000), while a similar
> machine with a HD panel (1366x768) shows 76300.  So, I'm not sure
> whether 112MHz could be a right threshold.

Hm, fair point.

Would be interesting to compare the VBTs between the two boots.  The
lvds_fp_timing struct might actually have the data we want here
regardless of how the machine booted.

- ajax

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2012-03-14 18:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14 12:37 Thinkpad T420 and single/dual channel lvds Helge Bahmann
2012-03-14 14:45 ` Adam Jackson
2012-03-14 16:44   ` Takashi Iwai
2012-03-14 18:09     ` Adam Jackson [this message]
2012-03-15 13:15       ` Takashi Iwai
2012-03-15 13:25         ` Chris Wilson
2012-03-15 13:30           ` Takashi Iwai
2012-03-15 14:42             ` Takashi Iwai
2012-03-16 15:33               ` Rodrigo Vivi
2012-03-16 19:55               ` Adam Jackson
2012-03-16 20:29                 ` Takashi Iwai
2012-03-18 17:50                   ` Daniel Vetter
2012-03-18 18:01                     ` Andreas Heider
2012-03-18 20:26                       ` Takashi Iwai
2012-03-18 20:24                     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331748559.30864.14.camel@atropine \
    --to=ajax@redhat.com \
    --cc=hcb@chaoticmind.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.