Re: cpu_active vs pcrypt & padata

[Peter Zijlstra <peterz@infradead.org>]

On Fri, 2012-03-16 at 11:44 +0100, Steffen Klassert wrote:
> Hi.
> 
> On Fri, Mar 16, 2012 at 11:13:08AM +0100, Peter Zijlstra wrote:
> > Hi Steffen,
> > 
> > I found cpu_active usage in crypto/pcrypt.c and was wondering what
> > that's doing there. I would really like to contain that thing to as
> > narrow a piece of kernel as I possible can (sched/cpuset/hotplug) but it
> > appears to be spreading.
> 
> pcrypt uses cpu_active to tell padata which cpuset it whishes
> to use for parallelization. I could try to push the cpumask
> handling down to padata if you want to limit this to the core
> kernel.

/me more confused now.. cpu_active isn't in any way shape or form
related to cpusets.

> > Also, wth is all this kernel/padata.c stuff? There's next to no useful
> > comment in there and the only consumer seems to be pcrypt, does that
> > really need to be in kernel/ ?
> 
> The padata code is generic and not limited to crypto, you can find
> a documentation at Documentation/padata.txt.

Would be nice to have a short blurb in kernel/padata.c with a reference
to that Documentation stuff for more in-depth bits.