From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>
Subject: Re: arm-soc + rmk's tree boot failure on OMAP4430SDP
Date: Mon, 19 Mar 2012 15:02:43 +0200 [thread overview]
Message-ID: <1332162163.2144.77.camel@deskari> (raw)
In-Reply-To: <1332160864.2144.66.camel@deskari>
[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]
On Mon, 2012-03-19 at 14:41 +0200, Tomi Valkeinen wrote:
> On Mon, 2012-03-19 at 12:30 +0000, Russell King - ARM Linux wrote:
> > It is _very_ important that we discover what has caused this regression
> > and prevent it going upstream until the problem is resolved. Until we
> > know that, I suggest that _no_ OMAP changes go upstream during this
> > merge window until we understand what's caused this.
>
> I didn't try yet, but it could be this:
>
> commit 3ec2decbb6dfcdbbb6e6a8ddf5adc7edbc429ed7
> Author: Kevin Hilman <khilman@ti.com>
> Date: Wed Feb 15 11:47:45 2012 -0800
>
> ARM: OMAP: omap_device: remove omap_device_parent
Reverting that patch makes dss work again. I don't know all the details
of device/driver registration, but I guess the problem is this:
"omapdss" device is a platform_device, and there's no hwmod for it. The
dss subdrivers (which have a corresponding hwmod) are being registered
in omapdss-driver's probe. Previously the dss subdrivers had
"omap_device_parent" device as their parent, and this avoided the
deadlock between omapdss and the subdrivers.
Now, with that patch, both omapdss and dss subdrivers have
platform_driver as parent, causing the deadlock.
The patch does make sense, though. I hope nothing else than omapdss is
using the device framework in similar braindead way.
I'll see if I can make a single patch that fixes the issue. The patch
series I mentioned earlier does lots of things, but I think just moving
the driver registration out of the probe function should be enough to
avoid the problem.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-19 13:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 23:11 arm-soc + rmk's tree boot failure on OMAP4430SDP Russell King - ARM Linux
2012-03-17 0:47 ` Tony Lindgren
2012-03-17 21:15 ` Russell King - ARM Linux
2012-03-19 9:33 ` Tomi Valkeinen
2012-03-19 12:30 ` Russell King - ARM Linux
2012-03-19 12:41 ` Tomi Valkeinen
2012-03-19 12:59 ` Russell King - ARM Linux
2012-03-19 13:02 ` Tomi Valkeinen [this message]
2012-03-19 13:59 ` Tomi Valkeinen
2012-03-19 19:21 ` Tony Lindgren
2012-03-22 1:15 ` Russ Dill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332162163.2144.77.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=arnd@arndb.de \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.