From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerome Glisse <j.glisse@gmail.com>
Subject: Re: Why do flush page cache twice when change TT's cache attribute
Date: Mon, 19 Mar 2012 13:22:16 -0400
Message-ID: <1332177736.2986.3.camel@localhost.localdomain>
References: <CAHcdkt-B6kk2BmwRNT0C5o6VGNZPnT6e+v54CVc+5xVm2cw5cA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail-yx0-f177.google.com (mail-yx0-f177.google.com
	[209.85.213.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id B1D089ED77
	for <dri-devel@lists.freedesktop.org>;
	Mon, 19 Mar 2012 10:22:21 -0700 (PDT)
Received: by yenm10 with SMTP id m10so6412983yen.36
	for <dri-devel@lists.freedesktop.org>;
	Mon, 19 Mar 2012 10:22:21 -0700 (PDT)
In-Reply-To: <CAHcdkt-B6kk2BmwRNT0C5o6VGNZPnT6e+v54CVc+5xVm2cw5cA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Scott Fang <donnie.fang@gmail.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Mon, 2012-03-19 at 23:11 +0800, Scott Fang wrote:
> In function ttm_tt_set_caching
> ,,,,,,,
> 
>     if (ttm->caching_state == tt_cached)
>         drm_clflush_pages(ttm->pages, ttm->num_pages);
> 
>     for (i = 0; i < ttm->num_pages; ++i) {
>         cur_page = ttm->pages[i];
>         if (likely(cur_page != NULL)) {
>             ret = ttm_tt_set_page_caching(cur_page,
>                               ttm->caching_state,
>                               c_state);
>             if (unlikely(ret != 0))
>                 goto out_err;
>         }
>     }
> 
>     ttm->caching_state = c_state;
> 
>     return 0;
> 
> 
> drm_clflush_pages flush cache one time.
> then in the following function
> ttm_tt_set_page_caching->set_memory_wc->change_page_attr_set: in this
> function may flush page cache again.
> 
> Does the code do some abundant flush, or there is some trick to these
> codes?
> 
> Thanks for the answer in advance.

Yes there might be redundant flushing.

Cheers,
Jerome