All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin Cross <ccross@android.com>
To: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	John Stultz <john.stultz@linaro.org>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Android Kernel Team <kernel-team@android.com>,
	gregkh@linuxfoundation.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Colin Cross <ccross@android.com>
Subject: [PATCH] android: make persistent_ram based drivers depend on HAVE_MEMBLOCK
Date: Wed, 21 Mar 2012 10:18:33 -0700	[thread overview]
Message-ID: <1332350313-2501-1-git-send-email-ccross@android.com> (raw)

m68k doesn't have memblock_reserve, which causes a build failure
with allmodconfig.  Make PERSISTENT_RAM and RAM_CONSOLE depend on
HAVE_MEMBLOCK.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reported-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Colin Cross <ccross@android.com>
---
 drivers/staging/android/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

I can't test on m68k, but this disables the options if I remove
HAVE_MEMBLOCK from arm.

diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
index 08a3b11..eb1dee2 100644
--- a/drivers/staging/android/Kconfig
+++ b/drivers/staging/android/Kconfig
@@ -27,13 +27,14 @@ config ANDROID_LOGGER
 
 config ANDROID_PERSISTENT_RAM
 	bool
+	depends on HAVE_MEMBLOCK
 	select REED_SOLOMON
 	select REED_SOLOMON_ENC8
 	select REED_SOLOMON_DEC8
 
 config ANDROID_RAM_CONSOLE
 	bool "Android RAM buffer console"
-	depends on !S390 && !UML
+	depends on !S390 && !UML && HAVE_MEMBLOCK
 	select ANDROID_PERSISTENT_RAM
 	default n
 
-- 
1.7.7.3

             reply	other threads:[~2012-03-21 17:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-21 17:18 Colin Cross [this message]
2012-04-08  8:43 ` [PATCH] android: make persistent_ram based drivers depend on HAVE_MEMBLOCK Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332350313-2501-1-git-send-email-ccross@android.com \
    --to=ccross@android.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.