All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Larson <kergoth@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Christopher Larson <chris_larson@mentor.com>
Subject: [PATCH] powerpc: fix overly aggressive TUNE_PKGARCH set
Date: Thu, 22 Mar 2012 10:00:03 -0500	[thread overview]
Message-ID: <1332428403-25048-1-git-send-email-kergoth@gmail.com> (raw)

From: Christopher Larson <chris_larson@mentor.com>

There's a problem in arch-powerpc.inc today, wherein it directly sets
TUNE_PKGARCH, rather than setting TUNE_PKGARCH_tune-<tuning>. As a result,
more specific tuning files (e.g. ppce500mc) then see their
TUNE_PKGARCH_tune-<tuning> variable definitions no longer obeyed. As
a consequence, the TUNE_PKGARCH ends up as 'powerpc' or 'powerpc-nf' rather
than 'ppce500mc', which in turn causes a 'TUNE_PKGARCH not in PACKAGE_ARCHS'
failure in the build.

To fix, the .inc now sets TUNE_PKGARCH_tune-powerpc and
TUNE_PKGARCH_tune-powerpc-nf rather than TUNE_PKGARCH.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta/conf/machine/include/powerpc/arch-powerpc.inc |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/conf/machine/include/powerpc/arch-powerpc.inc b/meta/conf/machine/include/powerpc/arch-powerpc.inc
index c9b2829..f811a3e 100644
--- a/meta/conf/machine/include/powerpc/arch-powerpc.inc
+++ b/meta/conf/machine/include/powerpc/arch-powerpc.inc
@@ -21,13 +21,14 @@ ABIEXTENSION = "${@['','spe'][d.getVar('TARGET_FPU', True) in ['ppc-efd', 'ppc-e
 PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-hard" , "", "-nf", d)}"
 
 PPCPKGARCH = "${TUNE_ARCH}${PPCPKGSFX_FPU}"
-TUNE_PKGARCH ?= "${PPCPKGARCH}"
 
 # Basic tune definitions
-AVAILTUNES += "powerpc powerpc-nf" 
+AVAILTUNES += "powerpc powerpc-nf"
 TUNE_FEATURES_tune-powerpc-nf ?= "m32 fpu-soft"
+TUNE_PKGARCH_tune-powerpc-nf = "${PPCPKGARCH}"
 BASE_LIB_tune-powerpc-nf = "lib"
 PACKAGE_EXTRA_ARCHS_tune-powerpc-nf = "powerpc-nf"
 TUNE_FEATURES_tune-powerpc ?= "m32 fpu-hard"
+TUNE_PKGARCH_tune-powerpc = "${PPCPKGARCH}"
 BASE_LIB_tune-powerpc = "lib"
 PACKAGE_EXTRA_ARCHS_tune-powerpc = "powerpc"
-- 
1.7.7




             reply	other threads:[~2012-03-22 15:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-22 15:00 Christopher Larson [this message]
2012-03-22 15:08 ` [PATCH] powerpc: fix overly aggressive TUNE_PKGARCH set Chris Larson
2012-03-22 15:21   ` McClintock Matthew-B29882
2012-03-22 15:27     ` Chris Larson
2012-03-22 15:32       ` McClintock Matthew-B29882
2012-03-22 15:33         ` Chris Larson
2012-03-22 16:38           ` Richard Purdie
2012-03-22 16:53             ` [PATCH] arch-powerpc.inc: use default value of TUNE_PKGARCH Matthew McClintock
2012-03-22 17:54               ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332428403-25048-1-git-send-email-kergoth@gmail.com \
    --to=kergoth@gmail.com \
    --cc=chris_larson@mentor.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.