diff for duplicates of <1332593021.16159.27.camel@twins> diff --git a/a/content_digest b/N1/content_digest index dc5ebfa..04a6ae8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,8 +2,24 @@ "ref\020120324102751.GA29067@lizard\0" "From\0Peter Zijlstra <a.p.zijlstra@chello.nl>\0" "Subject\0Re: [PATCH 01/10] cpu: Introduce clear_tasks_mm_cpumask() helper\0" - "Date\0Sat, 24 Mar 2012 12:43:41 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Sat, 24 Mar 2012 13:43:41 +0100\0" + "To\0Anton Vorontsov <anton.vorontsov@linaro.org>\0" + "Cc\0Andrew Morton <akpm@linux-foundation.org>" + Oleg Nesterov <oleg@redhat.com> + Russell King <linux@arm.linux.org.uk> + Mike Frysinger <vapier@gentoo.org> + Benjamin Herrenschmidt <benh@kernel.crashing.org> + Richard Weinberger <richard@nod.at> + Paul Mundt <lethal@linux-sh.org> + KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> + John Stultz <john.stultz@linaro.org> + linux-arm-kernel@lists.infradead.org + linux-kernel@vger.kernel.org + uclinux-dist-devel@blackfin.uclinux.org + linuxppc-dev@lists.ozlabs.org + linux-sh@vger.kernel.org + user-mode-linux-devel@lists.sourceforge.net + " linux-mm@kvack.org\0" "\00:1\0" "b\0" "On Sat, 2012-03-24 at 14:27 +0400, Anton Vorontsov wrote:\n" @@ -29,4 +45,4 @@ "marked offline, so its not like new tasks will ever get this cpu set in\n" their mm mask. -ff0865630277adf213c0b743bfa1d1aad4b6c065552c9534ce43a638233fc327 +9899f06c6e03bc44558acb32c4986719c70058912cabd3efc5e6261cdf151af1
diff --git a/a/1.txt b/N2/1.txt index 75f0687..75f039c 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -7,14 +7,14 @@ On Sat, 2012-03-24 at 14:27 +0400, Anton Vorontsov wrote: > + for_each_process(p) { > + struct task_struct *t; > + -> + t = find_lock_task_mm(p); +> + t =3D find_lock_task_mm(p); > + if (!t) > + continue; > + cpumask_clear_cpu(cpu, mm_cpumask(t->mm)); > + task_unlock(t); > + } > + read_unlock(&tasklist_lock); -> +} +> +}=20 Why bother with the tasklist_lock at all anymore, afaict you could use rcu_read_lock() here. This all is called after the cpu is taken down and diff --git a/a/content_digest b/N2/content_digest index dc5ebfa..8f3efa6 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,8 +2,23 @@ "ref\020120324102751.GA29067@lizard\0" "From\0Peter Zijlstra <a.p.zijlstra@chello.nl>\0" "Subject\0Re: [PATCH 01/10] cpu: Introduce clear_tasks_mm_cpumask() helper\0" - "Date\0Sat, 24 Mar 2012 12:43:41 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Sat, 24 Mar 2012 13:43:41 +0100\0" + "To\0Anton Vorontsov <anton.vorontsov@linaro.org>\0" + "Cc\0Mike Frysinger <vapier@gentoo.org>" + user-mode-linux-devel@lists.sourceforge.net + linux-sh@vger.kernel.org + Richard Weinberger <richard@nod.at> + linuxppc-dev@lists.ozlabs.org + Oleg Nesterov <oleg@redhat.com> + linux-kernel@vger.kernel.org + linux-mm@kvack.org + Paul Mundt <lethal@linux-sh.org> + John Stultz <john.stultz@linaro.org> + KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> + Russell King <linux@arm.linux.org.uk> + Andrew Morton <akpm@linux-foundation.org> + uclinux-dist-devel@blackfin.uclinux.org + " linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Sat, 2012-03-24 at 14:27 +0400, Anton Vorontsov wrote:\n" @@ -15,18 +30,18 @@ "> + for_each_process(p) {\n" "> + struct task_struct *t;\n" "> +\n" - "> + t = find_lock_task_mm(p);\n" + "> + t =3D find_lock_task_mm(p);\n" "> + if (!t)\n" "> + continue;\n" "> + cpumask_clear_cpu(cpu, mm_cpumask(t->mm));\n" "> + task_unlock(t);\n" "> + }\n" "> + read_unlock(&tasklist_lock);\n" - "> +} \n" + "> +}=20\n" "\n" "Why bother with the tasklist_lock at all anymore, afaict you could use\n" "rcu_read_lock() here. This all is called after the cpu is taken down and\n" "marked offline, so its not like new tasks will ever get this cpu set in\n" their mm mask. -ff0865630277adf213c0b743bfa1d1aad4b6c065552c9534ce43a638233fc327 +76c54cf2397c3ac26a2758eef1724bde06f90084d021cd07ee0d887c6f32c5fb
diff --git a/a/content_digest b/N3/content_digest index dc5ebfa..1ed7de0 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,8 +1,8 @@ "ref\020120324102609.GA28356@lizard\0" "ref\020120324102751.GA29067@lizard\0" - "From\0Peter Zijlstra <a.p.zijlstra@chello.nl>\0" - "Subject\0Re: [PATCH 01/10] cpu: Introduce clear_tasks_mm_cpumask() helper\0" - "Date\0Sat, 24 Mar 2012 12:43:41 +0000\0" + "From\0a.p.zijlstra@chello.nl (Peter Zijlstra)\0" + "Subject\0[PATCH 01/10] cpu: Introduce clear_tasks_mm_cpumask() helper\0" + "Date\0Sat, 24 Mar 2012 13:43:41 +0100\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -29,4 +29,4 @@ "marked offline, so its not like new tasks will ever get this cpu set in\n" their mm mask. -ff0865630277adf213c0b743bfa1d1aad4b6c065552c9534ce43a638233fc327 +0fc2c37905dfc9000e7c279628265e6f9f2398d82b732559b0ad9e07295b2600
diff --git a/a/1.txt b/N4/1.txt index 75f0687..24b1c6f 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -20,3 +20,11 @@ Why bother with the tasklist_lock at all anymore, afaict you could use rcu_read_lock() here. This all is called after the cpu is taken down and marked offline, so its not like new tasks will ever get this cpu set in their mm mask. + + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N4/content_digest index dc5ebfa..ef5563b 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -2,8 +2,24 @@ "ref\020120324102751.GA29067@lizard\0" "From\0Peter Zijlstra <a.p.zijlstra@chello.nl>\0" "Subject\0Re: [PATCH 01/10] cpu: Introduce clear_tasks_mm_cpumask() helper\0" - "Date\0Sat, 24 Mar 2012 12:43:41 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Sat, 24 Mar 2012 13:43:41 +0100\0" + "To\0Anton Vorontsov <anton.vorontsov@linaro.org>\0" + "Cc\0Andrew Morton <akpm@linux-foundation.org>" + Oleg Nesterov <oleg@redhat.com> + Russell King <linux@arm.linux.org.uk> + Mike Frysinger <vapier@gentoo.org> + Benjamin Herrenschmidt <benh@kernel.crashing.org> + Richard Weinberger <richard@nod.at> + Paul Mundt <lethal@linux-sh.org> + KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> + John Stultz <john.stultz@linaro.org> + linux-arm-kernel@lists.infradead.org + linux-kernel@vger.kernel.org + uclinux-dist-devel@blackfin.uclinux.org + linuxppc-dev@lists.ozlabs.org + linux-sh@vger.kernel.org + user-mode-linux-devel@lists.sourceforge.net + " linux-mm@kvack.org\0" "\00:1\0" "b\0" "On Sat, 2012-03-24 at 14:27 +0400, Anton Vorontsov wrote:\n" @@ -27,6 +43,14 @@ "Why bother with the tasklist_lock at all anymore, afaict you could use\n" "rcu_read_lock() here. This all is called after the cpu is taken down and\n" "marked offline, so its not like new tasks will ever get this cpu set in\n" - their mm mask. + "their mm mask.\n" + "\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -ff0865630277adf213c0b743bfa1d1aad4b6c065552c9534ce43a638233fc327 +6be2c9f02e601fb11a0d1b52d5b43cf63871cf05a98afc62825a3e17e802f0c6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.