From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Dongxiao Xu <dongxiao.xu@intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 0/9 v3][PULL] Hob: Bug fixes: image_types, runqemu/deploy functionality filter, and DISTRO setting
Date: Sun, 25 Mar 2012 12:07:24 +0100 [thread overview]
Message-ID: <1332673644.28414.74.camel@ted> (raw)
In-Reply-To: <cover.1332589589.git.dongxiao.xu@intel.com>
On Sat, 2012-03-24 at 19:49 +0800, Dongxiao Xu wrote:
> Hi Richard,
>
> This is the third pull request for Hob bug fixes, please help to review and pull.
>
> Changes from v2:
> 1) Change the logic in set_distro(), that is, if defaultsetup is selected in Hob advanced setting dialog, we should leave DISTRO variable not set in bitbake server.
> 2) Add a new patch to avoid hardcode TMPDIR when executing runqemu.
>
> Thanks,
> Dongxiao
>
> The following changes since commit 0348ef08db9ac425d83126d2e6eb465adc28b110:
>
> Hob: Change the descriptions for view_recipe_button and view_package_button (2012-03-23 16:09:35 +0000)
>
> are available in the git repository at:
> git://git.pokylinux.org/poky-contrib dxu4/hob-bugfix
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-bugfix
>
> Dongxiao Xu (9):
> Hob: Remove unnecessary PARSE_BBFILES command
> Hob: Cleanup for hobeventhandler.py
> Hob: Initial an empty label in recipeselectionpage.py
> Hob: Change the Hob initialization process
> Hob: Fix the workaround to get image types
> Hob: Add a supported image type "vmdk"
> Hob: runqemu and deployment functionality filter
> Hob: Set empty DISTRO if "defaultsetup" is selected
> Hob: Avoid getting TMPDIR in hardcode
Merged to master, thanks.
I do have some concerns around the "runqemu and deployment functionality
filter" in that I'd prefer it if we treated the
RUNNABLE_MACHINE_PATTERNS as a proper regexp and matched it against
MACHINE rather than the image name. I'd prefer to see if behave like
COMPATIBLE_MACHINE for example.
This is a detail we can fix in subsequent patches though.
Cheers,
Richard
next prev parent reply other threads:[~2012-03-25 11:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 11:49 [PATCH 0/9 v3][PULL] Hob: Bug fixes: image_types, runqemu/deploy functionality filter, and DISTRO setting Dongxiao Xu
2012-03-24 11:49 ` [PATCH 1/9] Hob: Remove unnecessary PARSE_BBFILES command Dongxiao Xu
2012-03-24 11:49 ` [PATCH 2/9] Hob: Cleanup for hobeventhandler.py Dongxiao Xu
2012-03-24 11:49 ` [PATCH 3/9] Hob: Initial an empty label in recipeselectionpage.py Dongxiao Xu
2012-03-24 11:49 ` [PATCH 4/9] Hob: Change the Hob initialization process Dongxiao Xu
2012-03-24 11:49 ` [PATCH 5/9] Hob: Fix the workaround to get image types Dongxiao Xu
2012-03-24 11:49 ` [PATCH 6/9] Hob: Add a supported image type "vmdk" Dongxiao Xu
2012-03-24 11:49 ` [PATCH 7/9] Hob: runqemu and deployment functionality filter Dongxiao Xu
2012-03-24 11:49 ` [PATCH 8/9] Hob: Set empty DISTRO if "defaultsetup" is selected Dongxiao Xu
2012-03-24 11:49 ` [PATCH 9/9] Hob: Avoid getting TMPDIR in hardcode Dongxiao Xu
2012-03-25 11:07 ` Richard Purdie [this message]
2012-03-26 2:38 ` [PATCH 0/9 v3][PULL] Hob: Bug fixes: image_types, runqemu/deploy functionality filter, and DISTRO setting Xu, Dongxiao
2012-03-26 10:57 ` Richard Purdie
2012-03-27 0:45 ` Xu, Dongxiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332673644.28414.74.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=dongxiao.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.