From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/3] drm/i915: the intel gtt is _not_ an agp bridge! Date: Mon, 26 Mar 2012 09:49:36 +0100 Message-ID: <1332751786_97030@CP5-2952> References: <1332747942-2143-1-git-send-email-daniel.vetter@ffwll.ch> <1332747942-2143-2-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 54FBE9EB5D for ; Mon, 26 Mar 2012 01:49:49 -0700 (PDT) In-Reply-To: <1332747942-2143-2-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Mon, 26 Mar 2012 09:45:41 +0200, Daniel Vetter wrote: > So don't call it like that. > > Also rip out a confusing comment and instead explain what's really > going on. > > Signed-Off-by: Daniel Vetter > --- > +/* > + * This is really ugly: Because old userspace abused the linux agp interface to > + * manage the gtt, we need to claim that all intel devices are agp. For > + * otherwise the drm core refuses to initialize the agp support code. > */ So no new device entries, right? For the patch itself, Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre