From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 14/16] mm: extend prefault helpers to fault
	in more than PAGE_SIZE
Date: Mon, 26 Mar 2012 10:09:01 +0100
Message-ID: <1332752950_97244@CP5-2952>
References: <1332697663-31256-1-git-send-email-daniel.vetter@ffwll.ch>
	<1332697663-31256-14-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236])
	by gabe.freedesktop.org (Postfix) with ESMTP id 7ABCF9EEF9
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 26 Mar 2012 02:09:13 -0700 (PDT)
In-Reply-To: <1332697663-31256-14-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On Sun, 25 Mar 2012 19:47:41 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> +/*
> + * Multipage variants of the above prefault helpers, useful if more than
> + * PAGE_SIZE of date needs to be prefaulted. These are separate from the above
s/date/data/

> + * functions (which only handle up to PAGE_SIZE) to avoid clobbering the
> + * filemap.c hotpaths.
> + */

My only critique is that I'd still like the (a & PAGE_MASK) == (b &
PAGE_MASK) to be replaced with a readable macro.

#define same_page(a, b) (((unsigned long)(a) & PAGE_MASK) == ((unsigned long)(b) & PAGE_MASK))
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre