From: James Bottomley <jbottomley@parallels.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: "adobriyan@gmail.com" <adobriyan@gmail.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: Commit "arm: convert drivers to scsi proc_ops" breaks linux-next
Date: Tue, 27 Mar 2012 08:51:25 +0000 [thread overview]
Message-ID: <1332838284.2883.22.camel@dabdike> (raw)
In-Reply-To: <20120327025100.GD26825@windriver.com>
On Mon, 2012-03-26 at 22:51 -0400, Paul Gortmaker wrote:
> Hi Alexey,
>
> This error showed up in linux-next today:
>
> CC drivers/scsi/arm/powertec.o
> drivers/scsi/arm/powertec.c: In function 'powertecscsi_proc_show':
> drivers/scsi/arm/powertec.c:199: error: dereferencing pointer to incomplete type
> drivers/scsi/arm/powertec.c:202: error: implicit declaration of function 'seq_printf'
> drivers/scsi/arm/powertec.c: In function 'powertecscsi_proc_open':
> drivers/scsi/arm/powertec.c:214: error: implicit declaration of function 'single_open'
> drivers/scsi/arm/powertec.c: At top level:
> drivers/scsi/arm/powertec.c:250: error: 'seq_read' undeclared here (not in a function)
> drivers/scsi/arm/powertec.c:251: error: 'seq_lseek' undeclared here (not in a function)
> drivers/scsi/arm/powertec.c:252: error: 'single_release' undeclared here (not in a function)
>
> and a bisect leads to this:
>
> --------------
> commit bb6c20445c1bdd1c49ac5e76801211116694e3b9
> Author: Alexey Dobriyan <adobriyan@gmail.com>
> Date: Wed Feb 22 22:46:23 2012 +0300
>
> [SCSI] arm: convert drivers to scsi proc_ops
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
> --------------
Could you dig a little deeper on this one? seq_printf is defined in
include/linux/seq_file.h which is included by this commit. I can't see
why the function prototype should end up undefined.
Could the include guards for this file be getting set erroneously
somehow?
James
next prev parent reply other threads:[~2012-03-27 8:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 2:51 Commit "arm: convert drivers to scsi proc_ops" breaks linux-next Paul Gortmaker
2012-03-27 8:51 ` James Bottomley [this message]
2012-03-27 14:49 ` Stephen Rothwell
2012-03-27 20:05 ` [PATCH] scsi: arm: fix compilation Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332838284.2883.22.camel@dabdike \
--to=jbottomley@parallels.com \
--cc=adobriyan@gmail.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.