From: Colin Walters <walters@verbum.org>
To: Daniel J Walsh <dwalsh@redhat.com>
Cc: eparis@redhat.com, selinux@tycho.nsa.gov
Subject: Re: [PATCH 41/73] policycoreutils: mcstransd: write a pid file FIXME
Date: Tue, 27 Mar 2012 11:53:50 -0400 [thread overview]
Message-ID: <1332863630.15547.22.camel@lenny> (raw)
In-Reply-To: <4F71E181.80300@redhat.com>
On Tue, 2012-03-27 at 11:49 -0400, Daniel J Walsh wrote:
> This patch looks good to me. acked.
>
> systemd expects a pid file to be written by unit services.
It doesn't if the service is non-forking. In fact moving to
non-forking services that don't write pid files is a major
improvement that systemd brings over sysvinit, because the
state is 100% reliable. Pid files create the possibility
of desynchronization if the service crashes, but the pid
file remains.
So a better fix would be to change mcstransd to have a
--no-fork option, and update the unit file to use it.
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2012-03-27 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 15:49 [PATCH 41/73] policycoreutils: mcstransd: write a pid file FIXME Daniel J Walsh
2012-03-27 15:53 ` Colin Walters [this message]
2012-03-27 18:02 ` Daniel J Walsh
2012-03-28 16:24 ` Colin Walters
2012-03-28 17:23 ` Daniel J Walsh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332863630.15547.22.camel@lenny \
--to=walters@verbum.org \
--cc=dwalsh@redhat.com \
--cc=eparis@redhat.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.