From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Andi Kleen <andi@firstfloor.org>
Cc: "Yan, Zheng" <zheng.z.yan@intel.com>,
mingo@elte.hu, eranian@google.com, linux-kernel@vger.kernel.org,
ming.m.lin@intel.com
Subject: Re: [PATCH 2/5] perf: generic intel uncore support
Date: Wed, 28 Mar 2012 11:38:52 +0200 [thread overview]
Message-ID: <1332927532.2528.19.camel@twins> (raw)
In-Reply-To: <20120328092446.GY22197@one.firstfloor.org>
On Wed, 2012-03-28 at 11:24 +0200, Andi Kleen wrote:
> On Wed, Mar 28, 2012 at 02:43:15PM +0800, Yan, Zheng wrote:
> > +static void uncore_perf_event_update(struct intel_uncore_box *box,
> > + struct perf_event *event)
> > +{
> > + raw_spin_lock(&box->lock);
>
> I think a raw lock would be only needed if the uncore was called
> from the scheduler context switch, which it should not be.
>
> So you can use a normal lock instead of a raw lock.
Please ignore any and all feedback from wrongbot Andi, as said I'll
review the patches later this week.
next prev parent reply other threads:[~2012-03-28 9:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 6:43 [RFC PATCH 0/5] perf: Intel uncore pmu counting support Yan, Zheng
2012-03-28 6:43 ` [PATCH 1/5] perf: Export perf_assign_events Yan, Zheng
2012-03-28 6:43 ` [PATCH 2/5] perf: generic intel uncore support Yan, Zheng
2012-03-28 9:24 ` Andi Kleen
2012-03-28 9:38 ` Peter Zijlstra [this message]
2012-03-28 11:24 ` Yan, Zheng
2012-03-31 3:18 ` Peter Zijlstra
2012-04-01 3:11 ` Yan, Zheng
2012-04-02 22:10 ` Peter Zijlstra
2012-04-02 22:11 ` Peter Zijlstra
2012-04-03 8:28 ` Yan, Zheng
2012-04-03 14:29 ` Peter Zijlstra
2012-04-04 1:47 ` Yan, Zheng
2012-04-10 0:48 ` Yan, Zheng
2012-04-16 12:11 ` Peter Zijlstra
2012-04-02 22:16 ` Peter Zijlstra
2012-04-02 22:24 ` Peter Zijlstra
2012-04-16 12:07 ` Peter Zijlstra
2012-04-17 6:56 ` Yan, Zheng
2012-03-28 6:43 ` [PATCH 3/5] perf: Add Nehalem and Sandy Bridge " Yan, Zheng
2012-03-28 6:43 ` [PATCH 4/5] perf: Generic pci uncore device support Yan, Zheng
2012-03-28 6:43 ` [PATCH 5/5] perf: Add Sandy Bridge-EP uncore support Yan, Zheng
2012-03-28 6:49 ` [RFC PATCH 0/5] perf: Intel uncore pmu counting support Ingo Molnar
2012-03-28 8:49 ` Peter Zijlstra
2012-03-28 9:02 ` Yan, Zheng
2012-03-28 8:57 ` Andi Kleen
2012-03-28 9:30 ` Ingo Molnar
2012-03-28 10:58 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332927532.2528.19.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.