From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/8] drm: WARN() when drm_connector_attach_property fails Date: Thu, 29 Mar 2012 22:49:55 +0100 Message-ID: <1333057812_147497@CP5-2952> References: <1333056446-3383-1-git-send-email-przanoni@gmail.com> <1333056446-3383-2-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 601689F66B for ; Thu, 29 Mar 2012 14:50:17 -0700 (PDT) In-Reply-To: <1333056446-3383-2-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni , dri-devel@lists.freedesktop.org Cc: Paulo Zanoni List-Id: dri-devel@lists.freedesktop.org On Thu, 29 Mar 2012 18:27:20 -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Also return void instead of int. We have more than 100 callers and > no one checks for the return value. > > If this function fails the property won't be exposed by the get/set > ioctls, but we should probably survive. If this starts happening, > the solution will be to increase DRM_CONNECTOR_MAX_PROPERTY and > recompile the Kernel. Please add that to the error message and use printk_once() since we only really want to annoy the user the first time. -Chris -- Chris Wilson, Intel Open Source Technology Centre