Re: [PATCH RFC xf86-video-intel 1/2] Update the rotation property whenever we change the rotation.

[Chris Wilson <chris@chris-wilson.co.uk>]

On Thu, 29 Mar 2012 18:30:19 -0300, Paulo Zanoni <przanoni@gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Don't worry if that fails: only the KVMr feature will be affected.
> 
> We still need to change the sna/ code.
> We also need to add the dependency on libdrm.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>  src/intel.h         |    3 ++
>  src/intel_display.c |   80 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  src/intel_driver.c  |    2 +
>  3 files changed, 85 insertions(+), 0 deletions(-)
> 
> This is just an RFC. Read comment from Kernel patch 0007.
> 
> diff --git a/src/intel.h b/src/intel.h
> index f806aea..29df531 100644
> --- a/src/intel.h
> +++ b/src/intel.h
> @@ -644,4 +644,7 @@ static inline Bool intel_pixmap_is_offscreen(PixmapPtr pixmap)
>  	return priv && priv->offscreen;
>  }
>  
> +/* intel_display.c */
> +void intel_crtc_leave_vt(ScrnInfoPtr scrn);

This is the only minor issue I have with this patch (other than its
influx natiure ;). I would rather call this intel_mode_leave_vt() to
be consistent with the other callouts from intel_driver.c
Also consider whether we need to manually restore the rotation parameter
upon CloseScreen (shutdown). However, I strongly doubt that we should be
the ones to be restoring the rotation parameter, as it should be whoever
then assumes control of the vt establishes the mode to its liking. This
also covers the case of abnormal program termination and panics.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre