From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH RFC 1/2] drm: add bitmask property type
Date: Fri, 30 Mar 2012 09:44:36 +0100
Message-ID: <1333097091_153768@CP5-2952>
References: <1333069366-2774-1-git-send-email-rob.clark@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236])
	by gabe.freedesktop.org (Postfix) with ESMTP id 94CB29E907
	for <dri-devel@lists.freedesktop.org>;
	Fri, 30 Mar 2012 01:45:01 -0700 (PDT)
In-Reply-To: <1333069366-2774-1-git-send-email-rob.clark@linaro.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Rob Clark <rob.clark@linaro.org>, dri-devel@lists.freedesktop.org
Cc: Rob Clark <rob@ti.com>, patches@linaro.org
List-Id: dri-devel@lists.freedesktop.org

On Thu, 29 Mar 2012 20:02:45 -0500, Rob Clark <rob.clark@linaro.org> wrote:
> +	} else if (property->flags & DRM_MODE_PROP_BITMASK) {
> +		int i;
> +		__u64 valid_mask = 0;
> +		for (i = 0; i < property->num_values; i++)
> +			valid_mask |= (1 << property->values[i]);
This need to be 1LL << property->values[i].
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre