Re: [PATCH 5/8] runqueue.py: check results[0] in keys of build_pids before being used to avoid exceptions

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2012-03-30 at 06:10 +0000, Wang, Shane wrote:
> Richard Purdie wrote on 2012-03-30:
> 
> > On Thu, 2012-03-29 at 20:54 +0800, Shane Wang wrote:
> >> 
> >> 
> >> ne.wang@intel.com>
> >>                                To:
> >> bitbake-devel@lists.openembedded.org
> >>                           Subject:
> >> [bitbake-devel] [PATCH 5/8]
> >> runqueue.py: check results[0] in
> >> keys of build_pids before being
> >> used to avoid exceptions
> >>                              Date:
> >> Thu, 29 Mar 2012 20:54:54 +0800
> >> (29/03/12 13:54:54)
> >> 
> >> 
> >> [Yocto #2186]
> >> 
> >> Signed-off-by: Shane Wang <shane.wang@intel.com>
> >> ---
> >>  bitbake/lib/bb/runqueue.py |   20 ++++++++++++--------
> >>  1 files changed, 12 insertions(+), 8 deletions(-)
> > 
> > This kind of change sets off alarm bells. The big question is why are
> > you seeing exceptions? I suspect you're forking off processes within hob
> > which are then confusing the waitpid code. I'd have to ask why the UI is
> > forking processes when a build is running and why we're suddenly started
> > seeing this...
> The steps I did is to "Force stop" a build and click "build packages" to rebuild. Then I saw the exceptions.
> In the command mode, there is no issue because the process exits.

Ok, so what it sounds like is that waitpid() is not being called in the
"force stop" mode to collect the exit values of the processes. We should
fix the code to collect the exit values even in force stop mode.

Cheers,

Richard (resisting the urge to talk about reaping and zombies)