From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1333340517.30734.42.camel@pasglop> Subject: Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead From: Benjamin Herrenschmidt To: Andreas Schwab Date: Mon, 02 Apr 2012 14:21:57 +1000 In-Reply-To: References: <1329383368-12122-1-git-send-email-grant.likely@secretlab.ca> <1329383368-12122-7-git-send-email-grant.likely@secretlab.ca> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring , Milton Miller , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, 2012-04-01 at 23:27 +0200, Andreas Schwab wrote: > Grant Likely writes: > > > This patch drops the powerpc-specific irq_map table and replaces it with > > directly using the irq_alloc_desc()/irq_free_desc() interfaces for allocating > > and freeing irq_desc structures. > > This breaks irqs on PowerMac G5. I see lost irq errors from the sata > driver. > > Note that the breakage only started after the series was merged into > mainline. But when transplanted upon the parent of the merge this is > the commit that was blamed by bisect. So something changed between > v3.3-rc3 and the merge of this series that broke it. can you tell me more ? (What machine precisely, what .config etc...) ? I tested here on two G5's: - PowerMac7,3 aka Dual G5 AGP. This ones has U3 + K2 and uses cascaded MPICs - PowerMac11,2 aka Quad G5. This one has U4 + K2 and uses a single MPIC in the northbridge And both appear to work fine with today upstream (basically -rc1). Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 From: benh@kernel.crashing.org (Benjamin Herrenschmidt) Date: Mon, 02 Apr 2012 14:21:57 +1000 Subject: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead In-Reply-To: References: <1329383368-12122-1-git-send-email-grant.likely@secretlab.ca> <1329383368-12122-7-git-send-email-grant.likely@secretlab.ca> Message-ID: <1333340517.30734.42.camel@pasglop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, 2012-04-01 at 23:27 +0200, Andreas Schwab wrote: > Grant Likely writes: > > > This patch drops the powerpc-specific irq_map table and replaces it with > > directly using the irq_alloc_desc()/irq_free_desc() interfaces for allocating > > and freeing irq_desc structures. > > This breaks irqs on PowerMac G5. I see lost irq errors from the sata > driver. > > Note that the breakage only started after the series was merged into > mainline. But when transplanted upon the parent of the merge this is > the commit that was blamed by bisect. So something changed between > v3.3-rc3 and the merge of this series that broke it. can you tell me more ? (What machine precisely, what .config etc...) ? I tested here on two G5's: - PowerMac7,3 aka Dual G5 AGP. This ones has U3 + K2 and uses cascaded MPICs - PowerMac11,2 aka Quad G5. This one has U4 + K2 and uses a single MPIC in the northbridge And both appear to work fine with today upstream (basically -rc1). Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead Date: Mon, 02 Apr 2012 14:21:57 +1000 Message-ID: <1333340517.30734.42.camel@pasglop> References: <1329383368-12122-1-git-send-email-grant.likely@secretlab.ca> <1329383368-12122-7-git-send-email-grant.likely@secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Andreas Schwab Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Milton Miller , Thomas Gleixner , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Sun, 2012-04-01 at 23:27 +0200, Andreas Schwab wrote: > Grant Likely writes: > > > This patch drops the powerpc-specific irq_map table and replaces it with > > directly using the irq_alloc_desc()/irq_free_desc() interfaces for allocating > > and freeing irq_desc structures. > > This breaks irqs on PowerMac G5. I see lost irq errors from the sata > driver. > > Note that the breakage only started after the series was merged into > mainline. But when transplanted upon the parent of the merge this is > the commit that was blamed by bisect. So something changed between > v3.3-rc3 and the merge of this series that broke it. can you tell me more ? (What machine precisely, what .config etc...) ? I tested here on two G5's: - PowerMac7,3 aka Dual G5 AGP. This ones has U3 + K2 and uses cascaded MPICs - PowerMac11,2 aka Quad G5. This one has U4 + K2 and uses a single MPIC in the northbridge And both appear to work fine with today upstream (basically -rc1). Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751121Ab2DBEWc (ORCPT ); Mon, 2 Apr 2012 00:22:32 -0400 Received: from gate.crashing.org ([63.228.1.57]:58336 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764Ab2DBEWb (ORCPT ); Mon, 2 Apr 2012 00:22:31 -0400 Message-ID: <1333340517.30734.42.camel@pasglop> Subject: Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead From: Benjamin Herrenschmidt To: Andreas Schwab Cc: Grant Likely , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Milton Miller , Rob Herring , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Date: Mon, 02 Apr 2012 14:21:57 +1000 In-Reply-To: References: <1329383368-12122-1-git-send-email-grant.likely@secretlab.ca> <1329383368-12122-7-git-send-email-grant.likely@secretlab.ca> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2012-04-01 at 23:27 +0200, Andreas Schwab wrote: > Grant Likely writes: > > > This patch drops the powerpc-specific irq_map table and replaces it with > > directly using the irq_alloc_desc()/irq_free_desc() interfaces for allocating > > and freeing irq_desc structures. > > This breaks irqs on PowerMac G5. I see lost irq errors from the sata > driver. > > Note that the breakage only started after the series was merged into > mainline. But when transplanted upon the parent of the merge this is > the commit that was blamed by bisect. So something changed between > v3.3-rc3 and the merge of this series that broke it. can you tell me more ? (What machine precisely, what .config etc...) ? I tested here on two G5's: - PowerMac7,3 aka Dual G5 AGP. This ones has U3 + K2 and uses cascaded MPICs - PowerMac11,2 aka Quad G5. This one has U4 + K2 and uses a single MPIC in the northbridge And both appear to work fine with today upstream (basically -rc1). Cheers, Ben.