From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: struct_mutex leak in i915_load_gem_init ? Date: Mon, 02 Apr 2012 22:01:46 +0100 Message-ID: <1333400529_206992@CP5-2952> References: <20120402203200.GZ2358@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id C9FD89E775 for ; Mon, 2 Apr 2012 14:02:16 -0700 (PDT) In-Reply-To: <20120402203200.GZ2358@deviant.kiev.zoral.com.ua> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Konstantin Belousov , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Mon, 2 Apr 2012 23:32:00 +0300, Konstantin Belousov wrote: > Hi, > it seems that in case of any i915_gem_init_aliasing_ppgtt() failure, > after the commit d3ae08109d628d26615d7f7f4d8d53cdd8d71fd0, the struct_mutex > lock leaks from i915_load_gem_init(). Right, I should have caught that before telling Daniel the patch was ok. :( -Chris -- Chris Wilson, Intel Open Source Technology Centre