From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1333409927.30734.62.camel@pasglop> Subject: Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead From: Benjamin Herrenschmidt To: Russell King - ARM Linux Date: Tue, 03 Apr 2012 09:38:47 +1000 In-Reply-To: <20120402225223.GN24211@n2100.arm.linux.org.uk> References: <1329383368-12122-1-git-send-email-grant.likely@secretlab.ca> <1329383368-12122-7-git-send-email-grant.likely@secretlab.ca> <20120402202848.1EB833E02A7@localhost> <20120402215524.GM24211@n2100.arm.linux.org.uk> <1333406005.30734.61.camel@pasglop> <20120402225223.GN24211@n2100.arm.linux.org.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring , Andreas Schwab , Milton Miller , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2012-04-02 at 23:52 +0100, Russell King - ARM Linux wrote: > If we want to fix it a better way, then sure, that'll be good. But > what > we shouldn't do is re-introduce one regression to fix a different > regression. > > So, Thomas, what do you think about providing a way that a disabled > interrupt could have its pending status cleared such that when it's > enabled, any queued events are ignored? Maybe an > enable_and_clear_irq() ? Ok. Doesn't matter anyway, this shouldn't be the problem in this specific case. IE. we shouldn't be setting that interrupt to NONE. We should have parsed the device-tree and set the trigger appropriately. Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 From: benh@kernel.crashing.org (Benjamin Herrenschmidt) Date: Tue, 03 Apr 2012 09:38:47 +1000 Subject: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead In-Reply-To: <20120402225223.GN24211@n2100.arm.linux.org.uk> References: <1329383368-12122-1-git-send-email-grant.likely@secretlab.ca> <1329383368-12122-7-git-send-email-grant.likely@secretlab.ca> <20120402202848.1EB833E02A7@localhost> <20120402215524.GM24211@n2100.arm.linux.org.uk> <1333406005.30734.61.camel@pasglop> <20120402225223.GN24211@n2100.arm.linux.org.uk> Message-ID: <1333409927.30734.62.camel@pasglop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 2012-04-02 at 23:52 +0100, Russell King - ARM Linux wrote: > If we want to fix it a better way, then sure, that'll be good. But > what > we shouldn't do is re-introduce one regression to fix a different > regression. > > So, Thomas, what do you think about providing a way that a disabled > interrupt could have its pending status cleared such that when it's > enabled, any queued events are ignored? Maybe an > enable_and_clear_irq() ? Ok. Doesn't matter anyway, this shouldn't be the problem in this specific case. IE. we shouldn't be setting that interrupt to NONE. We should have parsed the device-tree and set the trigger appropriately. Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead Date: Tue, 03 Apr 2012 09:38:47 +1000 Message-ID: <1333409927.30734.62.camel@pasglop> References: <1329383368-12122-1-git-send-email-grant.likely@secretlab.ca> <1329383368-12122-7-git-send-email-grant.likely@secretlab.ca> <20120402202848.1EB833E02A7@localhost> <20120402215524.GM24211@n2100.arm.linux.org.uk> <1333406005.30734.61.camel@pasglop> <20120402225223.GN24211@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120402225223.GN24211-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Russell King - ARM Linux Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Andreas Schwab , Milton Miller , Thomas Gleixner , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, 2012-04-02 at 23:52 +0100, Russell King - ARM Linux wrote: > If we want to fix it a better way, then sure, that'll be good. But > what > we shouldn't do is re-introduce one regression to fix a different > regression. > > So, Thomas, what do you think about providing a way that a disabled > interrupt could have its pending status cleared such that when it's > enabled, any queued events are ignored? Maybe an > enable_and_clear_irq() ? Ok. Doesn't matter anyway, this shouldn't be the problem in this specific case. IE. we shouldn't be setting that interrupt to NONE. We should have parsed the device-tree and set the trigger appropriately. Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753156Ab2DBXjd (ORCPT ); Mon, 2 Apr 2012 19:39:33 -0400 Received: from gate.crashing.org ([63.228.1.57]:46571 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751892Ab2DBXjc (ORCPT ); Mon, 2 Apr 2012 19:39:32 -0400 Message-ID: <1333409927.30734.62.camel@pasglop> Subject: Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead From: Benjamin Herrenschmidt To: Russell King - ARM Linux Cc: Grant Likely , Andreas Schwab , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Milton Miller , Rob Herring , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Date: Tue, 03 Apr 2012 09:38:47 +1000 In-Reply-To: <20120402225223.GN24211@n2100.arm.linux.org.uk> References: <1329383368-12122-1-git-send-email-grant.likely@secretlab.ca> <1329383368-12122-7-git-send-email-grant.likely@secretlab.ca> <20120402202848.1EB833E02A7@localhost> <20120402215524.GM24211@n2100.arm.linux.org.uk> <1333406005.30734.61.camel@pasglop> <20120402225223.GN24211@n2100.arm.linux.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2012-04-02 at 23:52 +0100, Russell King - ARM Linux wrote: > If we want to fix it a better way, then sure, that'll be good. But > what > we shouldn't do is re-introduce one regression to fix a different > regression. > > So, Thomas, what do you think about providing a way that a disabled > interrupt could have its pending status cleared such that when it's > enabled, any queued events are ignored? Maybe an > enable_and_clear_irq() ? Ok. Doesn't matter anyway, this shouldn't be the problem in this specific case. IE. we shouldn't be setting that interrupt to NONE. We should have parsed the device-tree and set the trigger appropriately. Cheers, Ben.