From: Chris Wilson <chris@chris-wilson.co.uk>
To: Xi Wang <xi.wang@gmail.com>, Keith Packard <keithp@keithp.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: fix integer overflow in i915_gem_execbuffer2()
Date: Fri, 06 Apr 2012 14:36:40 +0100 [thread overview]
Message-ID: <1333719431_271283@CP5-2952> (raw)
In-Reply-To: <1333717099-32679-1-git-send-email-xi.wang@gmail.com>
On Fri, 6 Apr 2012 08:58:18 -0400, Xi Wang <xi.wang@gmail.com> wrote:
> A large args->buffer_count from userspace may overflow the allocation
> size, leading to out-of-bounds access.
>
> Use kmalloc_array() to avoid that.
I can safely say that exec list larger than 4GiB is going to be an
illegal operation and would rather the ioctl failed outright with
EINVAL.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-04-06 13:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 12:58 [PATCH 1/2] drm/i915: fix integer overflow in i915_gem_execbuffer2() Xi Wang
2012-04-06 12:58 ` Xi Wang
2012-04-06 12:58 ` [PATCH 2/2] drm/i915: fix integer overflow in i915_gem_do_execbuffer() Xi Wang
2012-04-06 12:58 ` Xi Wang
2012-04-06 13:36 ` Chris Wilson [this message]
2012-04-06 13:46 ` [PATCH 1/2] drm/i915: fix integer overflow in i915_gem_execbuffer2() Xi Wang
2012-04-06 13:54 ` Chris Wilson
2012-04-06 13:54 ` Chris Wilson
2012-04-06 14:01 ` Xi Wang
2012-04-06 14:01 ` Xi Wang
2012-04-06 14:44 ` Chris Wilson
2012-04-06 14:44 ` Chris Wilson
2012-04-06 18:17 ` Xi Wang
2012-04-06 19:40 ` Chris Wilson
2012-04-06 20:34 ` Xi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333719431_271283@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.