From: philby john <pjohn@mvista.com>
To: linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
htejun@gmail.com
Subject: [PATCH] sil3531: has no PM capability, remove support.
Date: Mon, 09 Apr 2012 19:44:09 +0530 [thread overview]
Message-ID: <1333980849.11209.5.camel@localhost.localdomain> (raw)
From: Philby John <pjohn@mvista.com>
Date: Mon, 9 Apr 2012 19:09:51 +0530
Subject: [PATCH] sil3531: has no PM capability, remove support.
SATA sil3531 does not support Power Management Capability and
as per the manual Bit [31:27] is hardwired to 00h.
Otherwise, when the device goes into suspend/resume the Power
Management Control + Status registers are accessed and the
arch specific readl()/__raw_readl() calls block indefinitely.
This patch sets the PCI_DEV_FLAGS_NO_D3 flag by which the if
condition in pci_set_power_state() evaluates to true and
pci_raw_set_power_state() functions are not executed.
Signed-off-by: Philby John <pjohn@mvista.com>
Signed-off-by: Johnny Chiang <Johnny.Chiang@caviumnetworks.com>
---
drivers/pci/pci.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 8156744..129120d 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -1863,6 +1863,7 @@ void pci_pm_init(struct pci_dev *dev)
pci_pme_active(dev, false);
} else {
dev->pme_support = 0;
+ dev->dev_flags |= PCI_DEV_FLAGS_NO_D3;
}
}
--
1.6.3.3.340.g77d18
next reply other threads:[~2012-04-09 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 14:14 philby john [this message]
2012-04-09 14:51 ` [PATCH] sil3531: has no PM capability, remove support Jeff Garzik
2012-04-09 15:07 ` philby john
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333980849.11209.5.camel@localhost.localdomain \
--to=pjohn@mvista.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.