From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/3] drm/i915: make DP configuration vars less confusing in ironlake_crtc_mode_se Date: Tue, 10 Apr 2012 22:22:09 +0100 Message-ID: <1334092931_352626@CP5-2952> References: <1334084285-4770-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 111A29E74E for ; Tue, 10 Apr 2012 14:22:15 -0700 (PDT) In-Reply-To: <1334084285-4770-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 10 Apr 2012 11:58:03 -0700, Jesse Barnes wrote: > Both PCH and CPU eDP are DP, so set the is_dp flag to true. Add > is_cpu_edp and is_pch_edp bools to make checking for each less verbose > (rather than has_edp_encoder && !intel_encoder_is_pch_edp() sprinkled > everywhere). And rename the "has_edp_encoder" variable to just > "edp_encoder". > > With the above variables cleaned up, the rest of the code becomes a bit > more readable and clear. > > Signed-off-by: Jesse Barnes Ok, that took quite a bit of reading to be sure that the changes were consistent. Unfortunately it also looks to be in its simplest form. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre