From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/3] drm/i915: check PPS regs for sanity when using eDP Date: Tue, 10 Apr 2012 22:26:56 +0100 Message-ID: <1334093218_352690@CP5-2952> References: <1334084285-4770-1-git-send-email-jbarnes@virtuousgeek.org> <1334084285-4770-2-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 243A99E738 for ; Tue, 10 Apr 2012 14:27:02 -0700 (PDT) In-Reply-To: <1334084285-4770-2-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 10 Apr 2012 11:58:04 -0700, Jesse Barnes wrote: > If these regs don't have valid values, the panel won't come up, and may > even cause a system hang. So do a basic sanity check when an eDP panel > is detected. > > Signed-off-by: Jesse Barnes Other than adding a cleanup: error path (definitely before the third person cut'n'pastes the intel_dp*destroy()), and that checking for zero seems a little crude, Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre