From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/3] drm/i915: i915_gem_object_sync must handle NULL Date: Wed, 11 Apr 2012 19:41:04 +0100 Message-ID: <1334169670_371200@CP5-2952> References: <1334168301-4699-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 033669E819 for ; Wed, 11 Apr 2012 11:41:18 -0700 (PDT) In-Reply-To: <1334168301-4699-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Ben Widawsky , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Wed, 11 Apr 2012 11:18:19 -0700, Ben Widawsky wrote: > When I extracted the synchronization code for implementing semaphorified > pageflips (74f5f6e0), I neglected the non pipelined case which also > calls this code. The modesetting code wants to make sure the object has > finished rendering to the frame before configuring the scanout (ie. > non-pipelined case). > > As a result of a follow on discussion on IRC, I've decided to add a > comment about the function itself which received much inspiration from > Chris as well. So really, this patch was ghost-written by Chris :). > > Reported-by: Chris Wilson > Signed-off-by: Ben Widawsky Reviewed-by: Chris Wilson Tested-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre