From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/3] drm/i915: fix for when semaphore updates fail Date: Wed, 11 Apr 2012 19:42:43 +0100 Message-ID: <1334169769_371219@CP5-2952> References: <1334168301-4699-1-git-send-email-ben@bwidawsk.net> <1334168301-4699-2-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F4779EB5D for ; Wed, 11 Apr 2012 11:42:56 -0700 (PDT) In-Reply-To: <1334168301-4699-2-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Ben Widawsky , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Wed, 11 Apr 2012 11:18:20 -0700, Ben Widawsky wrote: > This fixes a long standing issue where emitting the semaphore updates > may have failed, but we've already updated our internal data structure. > > Reported-by: Daniel Vetter > Signed-off-by: Ben Widawsky I would have written it as ret == 0, but since I didn't write this, Reviewed-by: Chris Wilson Fortunately the impact of the bug would have been render corruption and not a GPU hang. -Chris -- Chris Wilson, Intel Open Source Technology Centre