From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <c_tpeder@qca.qualcomm.com>
Cc: kvalo@qca.qualcomm.com, ath6kl-devel@qualcomm.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 1/2] cfg80211: add channel switch notify event
Date: Thu, 12 Apr 2012 05:37:47 +0200 [thread overview]
Message-ID: <1334201867.3788.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1333744548-18028-1-git-send-email-c_tpeder@qca.qualcomm.com> (sfid-20120406_223557_026604_A9DD14C6)
On Fri, 2012-04-06 at 13:35 -0700, Thomas Pedersen wrote:
> /*
> + * cfg80211_ch_switch_notify - update wdev channel and notify userspace
> + * @dev: the device which switched channels
> + * @freq: new channel frequency (in MHz)
> + * @type: channel type
> + *
> + * Acquires wdev_lock, so must only be called from sleepable driver context!
> + */
> +void cfg80211_ch_switch_notify(struct net_device *dev, int freq,
> + enum nl80211_channel_type type);
I think this could be a bit more detailed -- the driver authors won't
know what wdev_lock is (nor care), but the other consequence of it is
that the function absolutely must not be called in the context of a
cfg80211 call into the driver.
johannes
prev parent reply other threads:[~2012-04-12 3:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 20:35 [PATCH v3 1/2] cfg80211: add channel switch notify event Thomas Pedersen
2012-04-06 20:35 ` [PATCH v3 2/2] ath6kl: handle concurrent AP-STA channel switches Thomas Pedersen
2012-04-09 15:05 ` Kalle Valo
2012-04-11 19:35 ` John W. Linville
2012-04-12 6:56 ` Kalle Valo
2012-04-12 3:37 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334201867.3788.2.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath6kl-devel@qualcomm.com \
--cc=c_tpeder@qca.qualcomm.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.