Re: [PATCH 05 of 10 [RFC]] xl: Explicit node affinity specification for guests via config file

[Dario Faggioli <raistlin@linux.it>]

[-- Attachment #1.1: Type: text/plain, Size: 1424 bytes --]

On Thu, 2012-04-12 at 11:48 +0100, David Vrabel wrote: 
> > Hmm, I think that using "affine" here is technically correct, and is
> > what one would use if writing a research paper; but it's unusual to hear
> > the word in more common English; it would be more common to hear someone
> > describe a VM as "having affinity with".  How about something like this:
> > 
> > "The list of NUMA nodes the domain is considered to have affinity with. 
> > Memory from the guest will be allocated from these nodes."
> 
> That's clunky sentence, the "considered" doesn't add anything.  Or perhaps:
> 
> "The NUMA nodes preferred by the guest.  Memory for the guest will be
> allocated on these nodes."
> 
Wow, that is even cooler, thanks! :-)

> The need for quotes around the node numbers is odd.  Can that
> requirement be removed?
> 
I'm not sure I ever checked/tried doing that. It's the plain libxl
parser for lists, which I've always seen taking strings in all the
examples I found, but I haven't ever looked at the actual code... I'll
figure that out and, if possible, get rid of them. I agree they're
disturbing.

Thanks,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel