From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Anton V. Boyarshinov" <boyarsh@altlinux.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] xf86drm.c: add counter for ioctl restarting
Date: Fri, 13 Apr 2012 14:40:58 +0100 [thread overview]
Message-ID: <1334324469_408990@CP5-2952> (raw)
In-Reply-To: <20120413172642.4c423352@boyarsh.office.altlinux.ru>
On Fri, 13 Apr 2012 17:26:42 +0400, "Anton V. Boyarshinov" <boyarsh@altlinux.org> wrote:
> In some cases ioclt->alarm->ioctl loop can be infinite:
> ioctl(7, 0x40086482, 0xbfb62738) = ? ERESTARTSYS (To be restarted)
> --- SIGALRM (Alarm clock) @ 0 (0) ---
> sigreturn() = ? (mask now [])
> ioctl(7, 0x40086482, 0xbfb62738) = ? ERESTARTSYS (To be restarted)
> and forever.
>
> It seems, that limiting ioctl restarting by some resonable number of trys
> is a dirty but working way to prevent Xorg lockups.
And you have audited all callpaths to make sure that they can handle
EINTR? Up until now it was part of the libdrm api that it did not return
EINTR...
>From my naive pov, we could just fix the root cause of the bug rather
than escalating the bug into a random failure.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-04-13 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 13:26 [PATCH] xf86drm.c: add counter for ioctl restarting Anton V. Boyarshinov
2012-04-13 13:40 ` Chris Wilson [this message]
2012-04-16 8:45 ` Anton V. Boyarshinov
2012-04-13 13:42 ` Daniel Vetter
2012-04-13 14:45 ` Ville Syrjälä
2012-04-16 8:54 ` Anton V. Boyarshinov
2012-04-16 14:12 ` Adam Jackson
2012-04-16 15:05 ` Anton V. Boyarshinov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334324469_408990@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=boyarsh@altlinux.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.