From: Artem Bityutskiy <dedekind1@gmail.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Subject: Re: [PATCH v2 3/4] fat: mark superblock as dirty less often
Date: Sat, 14 Apr 2012 14:08:18 +0300 [thread overview]
Message-ID: <1334401700.2263.26.camel@koala> (raw)
In-Reply-To: <877gxiha4b.fsf@devron.myhome.or.jp>
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
On Sat, 2012-04-14 at 19:37 +0900, OGAWA Hirofumi wrote:
> > But could you please explain why do we need an extra variable? What is
> > the problem with doing all our FAT table changes and then marking the
> > FSINFO as dirty?
>
> Above example may not be proper. I meant please dirty FSINFO only if
> necessary. Your patch seems to be dirty even if code didn't change
> FSINFO.
Ah, yes, in 'fat_alloc_clusters()' indeed, thanks, I'll fix this.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2012-04-14 11:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 14:19 [PATCH v2 v2 0/4] do not use s_dirt in FAT FS Artem Bityutskiy
2012-04-13 14:19 ` [PATCH v2 1/4] fat: introduce special inode for managing the FSINFO block Artem Bityutskiy
2012-04-13 14:19 ` [PATCH v2 2/4] fat: introduce mark_fsinfo_dirty helper Artem Bityutskiy
2012-04-13 14:19 ` [PATCH v2 3/4] fat: mark superblock as dirty less often Artem Bityutskiy
2012-04-14 9:17 ` OGAWA Hirofumi
2012-04-14 10:24 ` Artem Bityutskiy
2012-04-14 10:37 ` OGAWA Hirofumi
2012-04-14 11:08 ` Artem Bityutskiy [this message]
2012-04-13 14:19 ` [PATCH v2 4/4] fat: switch to fsinfo_inode Artem Bityutskiy
2012-04-14 10:19 ` OGAWA Hirofumi
2012-04-14 10:29 ` Artem Bityutskiy
2012-04-14 10:36 ` OGAWA Hirofumi
2012-04-14 11:01 ` Artem Bityutskiy
2012-04-14 11:51 ` OGAWA Hirofumi
2012-04-14 12:36 ` Artem Bityutskiy
2012-04-14 13:12 ` OGAWA Hirofumi
2012-04-14 13:54 ` Artem Bityutskiy
2012-05-04 10:13 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334401700.2263.26.camel@koala \
--to=dedekind1@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=artem.bityutskiy@linux.intel.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.