From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: don't clobber the special upscaling lvds timings Date: Sat, 14 Apr 2012 18:05:24 +0100 Message-ID: <1334423133_103@CP5-2952> References: <1334420277-19302-1-git-send-email-daniel.vetter@ffwll.ch> <1334421840_64@CP5-2952> <20120414165446.GB4215@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 47BC99ED69 for ; Sat, 14 Apr 2012 10:05:39 -0700 (PDT) In-Reply-To: <20120414165446.GB4215@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Sat, 14 Apr 2012 18:54:46 +0200, Daniel Vetter wrote: > To contrast with the state before these two patches: > - No longer splattered all over (some of it was deep down in the encoder > code, e.g. sdvo). > - No more stupid confusion about interlaced timings. Good things for sure. My biggest concern is that we have conflicting requirements upon the mode as setup in crtcinfo that are not being detected. The task of mode-valid is to find a compromise mode that works for all attached connectors, and more importantly make sure we reject combinations of connectors that would result in no compatible modes (above and beyond the combination of encoders that are illegal). And most of that concern is due to the fact that the modesetting code seems to have evolved ad-hoc with very few sanity checks and no overarching design. -Chris -- Chris Wilson, Intel Open Source Technology Centre