From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Suppress EIO during set-to-cpu-domain Date: Sat, 14 Apr 2012 23:24:30 +0100 Message-ID: <1334442282_859@CP5-2952> References: <1334395461-10285-1-git-send-email-chris@chris-wilson.co.uk> <20120414221615.GG4215@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 283AAA1183 for ; Sat, 14 Apr 2012 15:24:44 -0700 (PDT) In-Reply-To: <20120414221615.GG4215@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, 15 Apr 2012 00:16:15 +0200, Daniel Vetter wrote: > On Sat, Apr 14, 2012 at 10:24:21AM +0100, Chris Wilson wrote: > > If the hardware is dead, we can simply discard any outstanding writes > > from the GPU and presume the buffer is either in the GTT domain or > > already in the CPU domain and continue on flushing the CPU caches. > > > > Signed-off-by: Chris Wilson > > Pardon my ignorance, but I fail to see the goal of these -EIO patches ... > Care to mind the dense? I encountered a page-fault-of-doom, due to i915_gem_fault() spinning on a flush. i915_gem_reset() should fixup the buffers to prevent that. However, I thought the EIO checks served as nice documentation along paths that simply did not care why the GPU was no longer accessing the buffer only that it wasn't. -Chris -- Chris Wilson, Intel Open Source Technology Centre