From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx145.postini.com [74.125.245.145]) by kanga.kvack.org (Postfix) with SMTP id 0E90C6B004A for ; Sun, 15 Apr 2012 06:51:35 -0400 (EDT) Message-ID: <1334487062.2528.113.camel@twins> Subject: Re: [RFC 0/6] uprobes: kill uprobes_srcu/uprobe_srcu_id From: Peter Zijlstra Date: Sun, 15 Apr 2012 12:51:02 +0200 In-Reply-To: <20120414205200.GA9083@redhat.com> References: <20120405222024.GA19154@redhat.com> <1334409396.2528.100.camel@twins> <20120414205200.GA9083@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Oleg Nesterov Cc: Ingo Molnar , Srikar Dronamraju , Andrew Morton , Linus Torvalds , Ananth N Mavinakayanahalli , Jim Keniston , LKML , Linux-mm , Andi Kleen , Christoph Hellwig , Steven Rostedt , Arnaldo Carvalho de Melo , Masami Hiramatsu , Thomas Gleixner , Anton Arapov On Sat, 2012-04-14 at 22:52 +0200, Oleg Nesterov wrote: > > > - can it work or I missed something "in general" ? > > > > So we insert in the rb-tree before we take mmap_sem, this means we can > > hit a non-uprobe int3 and still find a uprobe there, no? >=20 > Yes, but unless I miss something this is "off-topic", this > can happen with or without these changes. If find_uprobe() > succeeds we assume that this bp was inserted by uprobe. OK, but then I completely missed what the point of that=20 down_write() stuff is.. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753553Ab2DOKvl (ORCPT ); Sun, 15 Apr 2012 06:51:41 -0400 Received: from merlin.infradead.org ([205.233.59.134]:52257 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752366Ab2DOKvk convert rfc822-to-8bit (ORCPT ); Sun, 15 Apr 2012 06:51:40 -0400 Message-ID: <1334487062.2528.113.camel@twins> Subject: Re: [RFC 0/6] uprobes: kill uprobes_srcu/uprobe_srcu_id From: Peter Zijlstra To: Oleg Nesterov Cc: Ingo Molnar , Srikar Dronamraju , Andrew Morton , Linus Torvalds , Ananth N Mavinakayanahalli , Jim Keniston , LKML , Linux-mm , Andi Kleen , Christoph Hellwig , Steven Rostedt , Arnaldo Carvalho de Melo , Masami Hiramatsu , Thomas Gleixner , Anton Arapov Date: Sun, 15 Apr 2012 12:51:02 +0200 In-Reply-To: <20120414205200.GA9083@redhat.com> References: <20120405222024.GA19154@redhat.com> <1334409396.2528.100.camel@twins> <20120414205200.GA9083@redhat.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2012-04-14 at 22:52 +0200, Oleg Nesterov wrote: > > > - can it work or I missed something "in general" ? > > > > So we insert in the rb-tree before we take mmap_sem, this means we can > > hit a non-uprobe int3 and still find a uprobe there, no? > > Yes, but unless I miss something this is "off-topic", this > can happen with or without these changes. If find_uprobe() > succeeds we assume that this bp was inserted by uprobe. OK, but then I completely missed what the point of that down_write() stuff is..