From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: Marek Vasut <marex@denx.de>,
u-boot@lists.denx.de, Jonas Karlman <jonas@kwiboo.se>,
Soeren Moch <smoch@web.de>,
Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Tim Harvey <tharvey@gateworks.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Anand Moon <linux.amoon@gmail.com>,
Maxim Kiselev <bigunclemax@gmail.com>
Subject: Re: [PATCH v2 0/4] USB-PD TCPM improvements
Date: Thu, 27 Mar 2025 18:08:20 +0100 [thread overview]
Message-ID: <13345767.O9o76ZdvQC@workhorse> (raw)
In-Reply-To: <20250226184506.64114-1-sebastian.reichel@collabora.com>
On Wednesday, 26 February 2025 19:44:43 Central European Standard Time
Sebastian Reichel wrote:
> Hi,
>
> I have a couple of fixes/improvements for the TCPM code. Three are fixing
> actual problems I noticed on the Rock 5B, which prevented booting up the
> system. One of them simply adds an error print before potentially committing
> hara-kiri by triggering a hard reset, which helps people understanding why
> their boards reset themself in case there are more problems. I've recently
> added the same print to the kernel TCPM code.
>
> Changes since PATCHv1:
> *
> https://lore.kernel.org/u-boot/20241031175404.114773-5-sebastian.reichel@co
> llabora.com/ * rebased to v2025.04-rc3 (no changes needed)
>
> Greetings,
>
> -- Sebastian
>
> Sebastian Reichel (4):
> usb: tcpm: improve handling of some power-supplies
> usb: tcpm: avoid resets for missing source capability messages
> usb: tcpm: print error on hard reset
> usb: tcpm: improve data role mismatch error recovery
>
> drivers/usb/tcpm/tcpm-internal.h | 1 +
> drivers/usb/tcpm/tcpm.c | 95 ++++++++++++++++++++++++++++----
> 2 files changed, 85 insertions(+), 11 deletions(-)
Tested-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Used this series on our 2025.04-rc2-based Sige5 tree. Resolves a problem I've
observed with PD supplies where the board may bootloop within u-boot. Tested
with various USB-C PD sources and cables, all of which worked.
Thanks,
Nicolas Frattaroli
next prev parent reply other threads:[~2025-03-28 2:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 18:44 [PATCH v2 0/4] USB-PD TCPM improvements Sebastian Reichel
2025-02-26 18:44 ` [PATCH v2 1/4] usb: tcpm: improve handling of some power-supplies Sebastian Reichel
2025-02-26 18:44 ` [PATCH v2 2/4] usb: tcpm: avoid resets for missing source capability messages Sebastian Reichel
2025-02-26 18:44 ` [PATCH v2 3/4] usb: tcpm: print error on hard reset Sebastian Reichel
2025-02-26 18:44 ` [PATCH v2 4/4] usb: tcpm: improve data role mismatch error recovery Sebastian Reichel
2025-02-27 6:00 ` [PATCH v2 0/4] USB-PD TCPM improvements Anand Moon
2025-03-01 18:11 ` Peter Robinson
2025-03-03 7:38 ` Anand Moon
2025-03-03 16:06 ` Sebastian Reichel
2025-03-04 5:05 ` Anand Moon
2025-03-04 12:42 ` Sebastian Reichel
2025-03-04 14:50 ` Anand Moon
2025-03-06 19:00 ` Anand Moon
2025-03-07 9:29 ` Soeren Moch
2025-03-27 17:08 ` Nicolas Frattaroli [this message]
2025-06-18 9:36 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13345767.O9o76ZdvQC@workhorse \
--to=nicolas.frattaroli@collabora.com \
--cc=bigunclemax@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux.amoon@gmail.com \
--cc=marex@denx.de \
--cc=philipp.tomsich@vrull.eu \
--cc=sebastian.reichel@collabora.com \
--cc=smoch@web.de \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.