From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@redhat.com, mingo@elte.hu, paulus@samba.org,
cjashfor@linux.vnet.ibm.com, fweisbec@gmail.com,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
andi@firstfloor.org
Subject: Re: [RFCv2 0/8] perf tool: Add new event group management
Date: Mon, 16 Apr 2012 16:23:54 +0200 [thread overview]
Message-ID: <1334586234.28150.53.camel@twins> (raw)
In-Reply-To: <20120416121627.GA1660@m.brq.redhat.com>
On Mon, 2012-04-16 at 14:16 +0200, Jiri Olsa wrote:
> also, any thoughts about the displaying question? ;)
>
> > I'm looking on how to present this data in perf and it seems we need
> > to reset all siblings once we read/store them (in kernel) to the
> > leader sample.
> >
> > My current thinking is to store siblings' sum values for each
> > hists entry of the sample (perf report count unit) .. and display
> > them in similar way we display callchains: for each hists entry
> > display the sum value for each sibling.
> >
> > Could you provide more of your world examples? Your expectations about
> > presenting this..
> >
> > Maybe we want to make the reset optional, and do some do some other
> > math with siblings' values..?
My thought was to do the exact same thing with it that we do with the
regular multi-event thing (which could be improved too). Simply create
individual event views with variable period based on the sample delta
for that particular event.
So suppose you have a group of 3 with only the leader sampling and you
get tuples like:
IP=x {1000, 500, 750}
IP=y {2000, 800, 1500}
IP=z {3000, 1100, 2000}
This could be decomposed into 3 event views like:
IP=x,period=1000 IP=x,period=500 IP=x,period=750
IP=y,period=1000 IP=y,period=300 IP=y,period=750
IP=z,period=1000 IP=z,period=300 IP=z,period=500
Just like what would've happened if you'd used multiple events like:
attr = {
.sample_type = PERF_SAMPLE_IP|PERF_SAMPLE_PERIOD,
.freq = 1,
.sample_period = 1000,
}
next prev parent reply other threads:[~2012-04-16 14:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 21:16 [RFCv2 0/8] perf tool: Add new event group management Jiri Olsa
2012-04-04 21:16 ` [PATCH 1/8] perf, tool: Add support to parse event group syntax Jiri Olsa
2012-04-04 21:16 ` [PATCH 2/8] perf, tool: Enable grouping logic for parsed events Jiri Olsa
2012-04-04 21:16 ` [PATCH 3/8] perf: Add PERF_EVENT_IOC_ID ioctl to return event ID Jiri Olsa
2012-04-04 21:16 ` [PATCH 4/8] perf, tool: Use PERF_EVENT_IOC_ID perf ioctl to read event id Jiri Olsa
2012-04-04 21:16 ` [PATCH 5/8] perf, tool: Separate 'mem:' event scanner bits Jiri Olsa
2012-04-11 13:28 ` Robert Richter
2012-04-11 14:33 ` Jiri Olsa
2012-04-13 17:02 ` Robert Richter
2012-04-04 21:16 ` [PATCH 6/8] perf, tool: Add modifier support to group event syntax Jiri Olsa
2012-04-04 21:16 ` [PATCH 7/8] perf, tool: Add support for parsing PERF_SAMPLE_READ Jiri Olsa
2012-04-04 21:16 ` [PATCH 8/8] perf, tool: Enable sampling on specified event group leader Jiri Olsa
2012-04-04 21:21 ` [RFCv2 0/8] perf tool: Add new event group management Jiri Olsa
2012-04-15 15:16 ` Peter Zijlstra
2012-04-16 12:16 ` Jiri Olsa
2012-04-16 14:23 ` Peter Zijlstra [this message]
2012-04-16 15:26 ` Peter Zijlstra
2012-04-16 15:37 ` Jiri Olsa
2012-04-17 2:16 ` Namhyung Kim
2012-04-17 9:09 ` Namhyung Kim
2012-04-17 9:33 ` Jiri Olsa
2012-05-25 22:36 ` Andi Kleen
2012-05-26 12:38 ` Jiri Olsa
2012-05-26 19:23 ` Andi Kleen
2012-05-27 7:56 ` Ulrich Drepper
2012-05-27 15:08 ` Andi Kleen
2012-05-28 19:21 ` Jiri Olsa
2012-05-29 8:39 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334586234.28150.53.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.