From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Prefer to pageflip on the active ring on IvyBridge Date: Mon, 16 Apr 2012 15:36:13 +0100 Message-ID: <1334586986_8028@CP5-2952> References: <1334586581-15663-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CBDA9F103 for ; Mon, 16 Apr 2012 07:36:31 -0700 (PDT) Received: from cantiga.alporthouse.com (unverified [78.156.66.37]) by fireflyinternet.com (Firefly Internet SMTP) with ESMTP id 111323824-1500050 for ; Mon, 16 Apr 2012 15:36:26 +0100 In-Reply-To: <1334586581-15663-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 16 Apr 2012 15:29:41 +0100, Chris Wilson wrote: > + ring = obj->ring; > + if (ring == NULL || ring == &dev_priv->ring[RCS]) should have been: ring == &dev_priv->ring[VCS] This does require testing on IVB, since the BCS was choosen for a reason, I'm sure. -Chris -- Chris Wilson, Intel Open Source Technology Centre