From: Brian Norris <computersforpeace@gmail.com>
To: <linux-mtd@lists.infradead.org>
Cc: Viresh Kumar <viresh.kumar@st.com>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Vipin Kumar <vipin.kumar@st.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Florian Fainelli <ffainelli@freebox.fr>,
Jamie Iles <jamie@jamieiles.com>,
Mike Dunn <mikedunn@newsguy.com>,
Bastian Hecht <hechtb@gmail.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Kevin Cernekee <cernekee@gmail.com>, Lei Wen <leiwen@marvell.com>,
Axel Lin <axel.lin@gmail.com>, Li Yang <leoli@freescale.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Armando Visconti <armando.visconti@st.com>,
Liu Shuo <b35362@freescale.com>,
Thomas Gleixner <tglx@linutronix.de>,
Scott Branden <sbranden@broadcom.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Huang Shijie <b32955@freescale.com>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
Jiandong Zheng <jdzheng@broadcom.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH 0/2] mtd: nand: rework nand_ecc_ctrl interface for OOB
Date: Mon, 16 Apr 2012 15:35:53 -0700 [thread overview]
Message-ID: <1334615755-15418-1-git-send-email-computersforpeace@gmail.com> (raw)
Hello,
I made a proposal to change the nand_chip and nand_ecc_ctrl interfaces a few
weeks ago to address a problem I see with a new NAND controller I'm working
with. This new controller does not return OOB data easily when performing page
reads/writes. However, currently these interfaces assume that OOB data is
read/written to/from the nand_chip.oob_poi buffer, even when the high-level
user did not request OOB data. I need to break that assumption with my NAND
driver, and so I have developed the following changes to the NAND interfaces
(see patch descriptions for more info).
You can see the original proposal and a little discussion here:
http://lists.infradead.org/pipermail/linux-mtd/2012-March/040441.html
Note that I could not compile all the affected drivers, since some required
ARCH-specific builds that I am not familiar with.
Artem: can you perform your regular compile tests? I compile-tested as many as
I could.
Others: if you care about your driver, please compile test and review to be
sure I'm doing things safely for you. Because most in-kernel drivers seem to be
perfecly happy using nand_chip.oob_poi for OOB data unconditionally, I have not
struggled to port most of them to take advantage of this full change. However,
I might make an attempt eventually, if I can get the proper amount of review
support. I cannot test most of these drivers properly, and so I *need* your
reviewing and testing to prevent breakage.
Thanks for reviewing!
Brian
Brian Norris (2):
mtd: nand: add OOB argument to NAND {read,write}_page interfaces
mtd: nand: nand_do_{read,write}_ops - pass OOB buffer through
drivers/mtd/nand/atmel_nand.c | 7 +-
drivers/mtd/nand/bcm_umi_bch.c | 10 ++-
drivers/mtd/nand/bcm_umi_nand.c | 2 +-
drivers/mtd/nand/bf5xx_nand.c | 4 +-
drivers/mtd/nand/cafe_nand.c | 26 ++++---
drivers/mtd/nand/denali.c | 8 +-
drivers/mtd/nand/docg4.c | 12 ++--
drivers/mtd/nand/fsl_elbc_nand.c | 7 +-
drivers/mtd/nand/fsl_ifc_nand.c | 4 +-
drivers/mtd/nand/fsmc_nand.c | 3 +-
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 5 +-
drivers/mtd/nand/nand_base.c | 131 ++++++++++++++++++--------------
drivers/mtd/nand/pxa3xx_nand.c | 4 +-
drivers/mtd/nand/sh_flctl.c | 4 +-
include/linux/mtd/nand.h | 11 ++-
15 files changed, 132 insertions(+), 106 deletions(-)
--
1.7.5.4.2.g519b1
next reply other threads:[~2012-04-16 22:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 22:35 Brian Norris [this message]
2012-04-16 22:35 ` [PATCH 1/2] mtd: nand: add OOB argument to NAND {read, write}_page interfaces Brian Norris
2012-04-17 7:50 ` Matthieu CASTET
2012-04-18 3:44 ` Brian Norris
2012-04-19 16:50 ` Mike Dunn
2012-04-19 22:06 ` Brian Norris
2012-04-20 1:10 ` Jon Povey
2012-04-20 16:25 ` Mike Dunn
2012-04-20 19:19 ` Brian Norris
2012-04-20 16:17 ` Mike Dunn
2012-04-22 7:58 ` Shmulik Ladkani
2012-04-23 9:14 ` Bastian Hecht
2012-04-23 17:14 ` Mike Dunn
2012-04-24 6:02 ` Shmulik Ladkani
2012-04-25 13:17 ` Bastian Hecht
2012-04-17 14:29 ` [PATCH 1/2] mtd: nand: add OOB argument to NAND {read,write}_page interfaces Shmulik Ladkani
2012-04-18 4:11 ` [PATCH 1/2] mtd: nand: add OOB argument to NAND {read, write}_page interfaces Brian Norris
2012-04-18 7:56 ` Bastian Hecht
2012-04-18 9:37 ` Bastian Hecht
2012-04-18 16:22 ` Brian Norris
2012-04-19 9:26 ` Bastian Hecht
2012-04-16 22:35 ` [PATCH 2/2] mtd: nand: nand_do_{read, write}_ops - pass OOB buffer through Brian Norris
2012-04-18 11:52 ` [PATCH 2/2] mtd: nand: nand_do_{read,write}_ops " Shmulik Ladkani
2012-04-18 16:13 ` [PATCH 2/2] mtd: nand: nand_do_{read, write}_ops " Brian Norris
2012-04-18 19:43 ` [PATCH 2/2] mtd: nand: nand_do_{read,write}_ops " Shmulik Ladkani
2012-04-25 14:16 ` [PATCH 0/2] mtd: nand: rework nand_ecc_ctrl interface for OOB Artem Bityutskiy
2012-04-25 18:26 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334615755-15418-1-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=armando.visconti@st.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=axel.lin@gmail.com \
--cc=b32955@freescale.com \
--cc=b35362@freescale.com \
--cc=cernekee@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ffainelli@freebox.fr \
--cc=hechtb@gmail.com \
--cc=jamie@jamieiles.com \
--cc=jdzheng@broadcom.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=leiwen@marvell.com \
--cc=leoli@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mikedunn@newsguy.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=sbranden@broadcom.com \
--cc=shmulik.ladkani@gmail.com \
--cc=tglx@linutronix.de \
--cc=vipin.kumar@st.com \
--cc=viresh.kumar@st.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.