From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/1] drm/i915: split power-related items into intel_pm module Date: Tue, 17 Apr 2012 00:23:49 +0100 Message-ID: <1334618657_9970@CP5-2952> References: <1334617561-4400-1-git-send-email-eugeni.dodonov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 73E229E7AD for ; Mon, 16 Apr 2012 16:24:33 -0700 (PDT) In-Reply-To: <1334617561-4400-1-git-send-email-eugeni.dodonov@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Ben Widawsky , Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org On Mon, 16 Apr 2012 20:06:01 -0300, Eugeni Dodonov wrote: > As previously discussed on irc with Daniel, Ben and Jesse, This patch > moves the power-related functionality into intel_pm module, aiming at > simplifying the intel_display code and make it less cluttered. > > The functionality affected by this move are: clock gating, rc6 and rps, > display watermarks, display fifo-related items, cxsr and FBC. > > This simplifies intel_display by +/- 2800 lines of code and centralizes > most of the power-related items in one place to simplify future hardware > enablement and subsystems interaction. Diff is making this really difficult to verify that no functional change is taking place. Suggestions? A series of small commits? -Chris -- Chris Wilson, Intel Open Source Technology Centre