From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Only free the unpin_work if cancelled before being run
Date: Tue, 17 Apr 2012 10:53:24 +0100 [thread overview]
Message-ID: <1334656418_11970@CP5-2952> (raw)
In-Reply-To: <1334654978-16021-1-git-send-email-chris@chris-wilson.co.uk>
On Tue, 17 Apr 2012 10:29:38 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> The unpin worker frees it work struct and so during intel_crtc_disable
> we should only also free the work struct if cancel_work_sync() reports
> that it successfully cancelled the work prior to it being executed and
> thus avoid the double free.
>
> The impact is only for people unloading modules during a fullscreen game
> or movie playback, so extremely small.
Futher review (hunting for some sign of workqueue corruption, cf
https://bugs.freedesktop.org/show_bug.cgi?id=48798) says that if work is
non-NULL here it will not have been scheduled so cancel_work_sync() will
always return true.
Which also means that we have no way of waiting upon the scheduled
unpin_work. :|
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-04-17 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 9:29 [PATCH] drm/i915: Only free the unpin_work if cancelled before being run Chris Wilson
2012-04-17 9:47 ` Daniel Vetter
2012-04-17 9:53 ` Chris Wilson [this message]
2012-04-17 10:33 ` Daniel Vetter
2012-04-17 13:30 ` Chris Wilson
2012-04-17 13:44 ` Daniel Vetter
2012-04-17 13:45 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334656418_11970@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.