From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Dongxiao Xu <dongxiao.xu@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 1/1] scripts/bitbake: Remove sanity_info after run "bitbake -e"
Date: Tue, 17 Apr 2012 12:19:12 +0100 [thread overview]
Message-ID: <1334661552.616.78.camel@ted> (raw)
In-Reply-To: <3398cf01806d1d585e5b92c1ad36116021af86d3.1334648692.git.dongxiao.xu@intel.com>
On Tue, 2012-04-17 at 15:46 +0800, Dongxiao Xu wrote:
> With latest master, we found certain sanity check doesn't work
> (e.x., the network check). This is because it created the sanity_info
> file at the first time when running "bitbake -e" command in
> scripts/bitbake, therefore while running the real bitbake command,
> it finds that the sanity_check file does exist so it skip the network
> check.
>
> The fix is to remove the sanity_info file after running "bitbake -e"
> command.
>
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
> ---
> scripts/bitbake | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/bitbake b/scripts/bitbake
> index 3772d82..a6fb2e5 100755
> --- a/scripts/bitbake
> +++ b/scripts/bitbake
> @@ -73,6 +73,7 @@ if [ $needpseudo = "1" ]; then
> PSEUDOBINDIR=`cat $BUILDDIR/pseudodone`
> else
> PSEUDOBINDIR=`bitbake -e | grep STAGING_BINDIR_NATIVE=\" | cut -d '=' -f2 | cut -d '"' -f2`
> + rm -rf conf/sanity_info
> fi
> if [ -e "$PSEUDOBINDIR/pseudo" ]; then
> buildpseudo="0"
This forces the sanity tests to run on every bitbake run which is not
acceptable. We need to find a better solution.
This also sets off alarm bells in my mind. If the sanity tests are
failing, shouldn't they fail equally on a subsquent run of bitbake?
See my follow up patch which should fix this problem in a better way.
Cheers,
Richard
prev parent reply other threads:[~2012-04-17 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 7:46 [PATCH 0/1][PULL] scripts/bitbake: fix sanity check not functional issue Dongxiao Xu
2012-04-17 7:46 ` [PATCH 1/1] scripts/bitbake: Remove sanity_info after run "bitbake -e" Dongxiao Xu
2012-04-17 11:19 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334661552.616.78.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=dongxiao.xu@intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.